From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755224AbdERIYv (ORCPT ); Thu, 18 May 2017 04:24:51 -0400 Received: from verein.lst.de ([213.95.11.211]:57414 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253AbdERIYu (ORCPT ); Thu, 18 May 2017 04:24:50 -0400 Date: Thu, 18 May 2017 10:24:48 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Thomas Gleixner , Mark Gross , Tejun Heo , linuxppc-dev , linux-s390 , Linux Kernel Mailing List Subject: Re: [PATCH 2/9] timers: provide a "modern" variant of timers Message-ID: <20170518082448.GB3812@lst.de> References: <20170516114812.10660-1-hch@lst.de> <20170516114812.10660-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > b) give the union a name (breaks any reference to timer_list->func in C code): > > + union { > + void (*func)(struct timer_list *timer); > + void (*function)(unsigned long); > + } u; I'll look into that, as it seems a lot safer, and places outside the timer code shouldn't really touch it (although I bet they do, so more fixes for this series..) > I fear this breaks lockdep output, which turns the name of > the timer into a string that gets printed later. It should work > when these are macros, or a macro wrapping an inline function > like __init_timer is. Ok, I'll fix it up. Although this macro mess isn't really readable at all.