From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755373AbdERIdI (ORCPT ); Thu, 18 May 2017 04:33:08 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:51199 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755107AbdERIdF (ORCPT ); Thu, 18 May 2017 04:33:05 -0400 From: Arnd Bergmann To: Don Brace , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Kevin Barnett , Scott Benesh , Scott Teel , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: smartpqi: mark PM functions as __maybe_unused Date: Thu, 18 May 2017 10:32:18 +0200 Message-Id: <20170518083243.2927102-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:UzfLyfjwhqmZqp+bc6Qicok4TV3A6pVODTvAgJ1qZDw9U6EL6CS SX1TeykXaXvxgAK6ECHX2fvZJNxVws7ytDGFbcS+XBu4tCzP5SKg3yR6cGPB9emsaktEMBV K6Su6b8qi8ihDLcT20wPHUy0CfAihi36qcYK4Dc0ZHNrGfF0UZIj+vEUWIXuvjodGmFAY+N LTNoD9il8pzEhWIws4z2A== X-UI-Out-Filterresults: notjunk:1;V01:K0:XD8b0UKabYg=:F1/MhbcWRrIedmo0PuhEtc PQ27RbCdFqY2wFiyjQpLgmwQyWt9CFdIXV3lUIRyC071pM8MvJKdP0M9SbTWO64MRD5WOKWhv xcrkUlmbROda6YMv6ZEJD9X1P4jfPw5S8tbYkGRLfJAuma4dmnftGFCJnnS1mHK13Gnz1Zv7Z 6W4yO+/YUP05Z6caZ7Sz+I+CkeIJFDCOuZ0JTDmNb4sgosB+TPn7NIHrVcx57QnGY3/UNvCLe GxQjm2hZl558UiwVgalJAz0MB6l4y/AUYbDxddglvXAP+7kaMNEaoUUonVIWyTzip7w6TliLP oKdEEWYMaRLIZSrJxirqc65J08C2lPicXfeKTo77XaYGYS/lVe/m9We3ns7vde/L6nMT5ylfm g0ep9pNo+h5ubDe3tlJusZlfamu0UyqRfeVLEqxjugQxFo8mj8/dKtC3JVhonULF/AEQQd6xQ o1t3ylPpFoYhRJ2/ac1gVfWVvjq3VCfZv7ZIDsgRUA1AyTd5pBPyCPsWX+OAXufBl+lIG4WDC W4ayO2o7jpwmwrYUHL/ql3cpHahlezTA/aeaWW3EqR6+TGU+8wxBKFsA7e2Dugb377U0nWeOl YmSN67jl/d9WZKlh2/6z3KBMKkScO9PNjUPMGoRv6xXKT9ugwpFpIFREUR7rQuazO/koOqmbj 7PUC3bmFshcq/ZR1brKoyEstWdztzlclz9e5usL8WzeDo0qAnkyOKlVyI9AuVSr5S2/M= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added suspend/resume support causes harmless warnings when CONFIG_PM is disabled: smartpqi/smartpqi_init.c:5147:12: error: 'pqi_ctrl_wait_for_pending_io' defined but not used [-Werror=unused-function] smartpqi/smartpqi_init.c:2019:13: error: 'pqi_wait_until_lun_reset_finished' defined but not used [-Werror=unused-function] smartpqi/smartpqi_init.c:2013:13: error: 'pqi_wait_until_scan_finished' defined but not used [-Werror=unused-function] We can avoid the warnings by removing the #ifdef around the handlers and instead marking them as __maybe_unused, which will let gcc drop the unused code silently. Fixes: f44d210312a6 ("scsi: smartpqi: add suspend and resume support") Signed-off-by: Arnd Bergmann --- drivers/scsi/smartpqi/smartpqi_init.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 0b11ae7e96dc..cb8f886e705c 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -6213,8 +6213,6 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info) return 0; } -#if defined(CONFIG_PM) - static void pqi_reinit_queues(struct pqi_ctrl_info *ctrl_info) { unsigned int i; @@ -6321,8 +6319,6 @@ static int pqi_ctrl_init_resume(struct pqi_ctrl_info *ctrl_info) return 0; } -#endif /* CONFIG_PM */ - static inline int pqi_set_pcie_completion_timeout(struct pci_dev *pci_dev, u16 timeout) { @@ -6696,9 +6692,7 @@ static void pqi_process_module_params(void) pqi_process_lockup_action_param(); } -#if defined(CONFIG_PM) - -static int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state) +static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state) { struct pqi_ctrl_info *ctrl_info; @@ -6728,7 +6722,7 @@ static int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state) return 0; } -static int pqi_resume(struct pci_dev *pci_dev) +static __maybe_unused int pqi_resume(struct pci_dev *pci_dev) { int rc; struct pqi_ctrl_info *ctrl_info; @@ -6759,8 +6753,6 @@ static int pqi_resume(struct pci_dev *pci_dev) return pqi_ctrl_init_resume(ctrl_info); } -#endif /* CONFIG_PM */ - /* Define the PCI IDs for the controllers that we support. */ static const struct pci_device_id pqi_pci_id_table[] = { { -- 2.9.0