From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754890AbdERJ0h (ORCPT ); Thu, 18 May 2017 05:26:37 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57825 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbdERJ0e (ORCPT ); Thu, 18 May 2017 05:26:34 -0400 Date: Thu, 18 May 2017 02:26:30 -0700 From: Christoph Hellwig To: Gabriele Paoloni Cc: bhelgaas@google.com, helgaas@kernel.org, linuxarm@huawei.com, linux-pci@vger.kernel.org, lukas@wunner.de, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, hch@infradead.org, liudongdong3@huawei.com Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Message-ID: <20170518092630.GA28006@infradead.org> References: <1495098098-1984-1-git-send-email-gabriele.paoloni@huawei.com> <1495098098-1984-2-git-send-email-gabriele.paoloni@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495098098-1984-2-git-send-email-gabriele.paoloni@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as interrupt mode > + * for given port just rename it to pcie_port_enable_vecs to avoid the overly long line.. > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case As mentioned in the review for the other patch: no need to repeat this for every user of pci_irq_vector. Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig