From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934273AbdERL3Z (ORCPT ); Thu, 18 May 2017 07:29:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45436 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933789AbdERL3W (ORCPT ); Thu, 18 May 2017 07:29:22 -0400 Date: Thu, 18 May 2017 12:28:46 +0100 From: Mark Brown To: SF Markus Elfring Cc: linux-spi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Message-ID: <20170518112846.tcirhguyps3kk3ra@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7nt3fc253c7bqiji" Content-Disposition: inline In-Reply-To: X-Cookie: Dealer prices may vary. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] spidev: Adjust five checks for null pointers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7nt3fc253c7bqiji Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2017 at 05:47:29PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 May 2017 17:30:28 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit Please fix however you're sending things out to avoid this noise. > The script =E2=80=9Ccheckpatch.pl=E2=80=9D pointed information out like t= he following. >=20 > Comparison to NULL could be written !=E2=80=A6 >=20 > Thus fix the affected source code places. This changelog does not describe any purpose in making this change, we could equally well say the exact opposite. Why should we do this? --7nt3fc253c7bqiji Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkdhWkACgkQJNaLcl1U h9A6fgf9HXPPR89iuEWigyaQPZ6M+FvaSSXYVHuV1Qz2eSSP2R7wiNONmL6ZFyV9 K+WrW24VvBomWdwFQNxCYdDhmQN23nJgX+SPV100cSwVrwkqwWJ+jNYatDKEJhlr PMhm+Fe5uwPMydGM97EO+R1OZ+4entJ3UYYYYVxnGuXBJFoGlWMvjB6wGctzT6V4 kxaTppgYuGTIi24k5H5rvi6RLEE5bswR1t1Kb9j5UnscUNBm1x3Cje0KIN3YXA7m OLUH1lwOW/oTNowwrunPIkeUhoUc/6xpvMOxV276wY2AsDrIQ+RB75eITMmHz/q6 nVfFZxPK4PTaQZaEIKqMG9eMSbkFtg== =Qx/I -----END PGP SIGNATURE----- --7nt3fc253c7bqiji--