From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933538AbdERLnn (ORCPT ); Thu, 18 May 2017 07:43:43 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56623 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933210AbdERLnj (ORCPT ); Thu, 18 May 2017 07:43:39 -0400 Date: Thu, 18 May 2017 13:43:23 +0200 From: Peter Zijlstra To: Florian Weimer Cc: Markus Trippelsdorf , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: commit cfafcd117 "futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()" causes glibc nptl/tst-robustpi8 failure Message-ID: <20170518114323.um3znbcoaxo7woo3@hirez.programming.kicks-ass.net> References: <20170517173646.GA281@x4> <20170518074054.qbqqdxtxwhnmkydz@hirez.programming.kicks-ass.net> <957d4eae-1078-6529-e3d1-d94dc9d2b6f0@redhat.com> <20170518083149.gs4o5tfyvkbi5ncs@hirez.programming.kicks-ass.net> <665ea364-3967-407d-4039-983ec95ad171@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <665ea364-3967-407d-4039-983ec95ad171@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 10:34:34AM +0200, Florian Weimer wrote: > On 05/18/2017 10:31 AM, Peter Zijlstra wrote: > > But it does that after building the tst-robustpi8 thing, so I seem to > > have all I need here. > > Great, have fun figuring out what's going on. :-/ ld-linux-x86-64-2165 [018] .... 290.235869: sched_process_fork: comm=ld-linux-x86-64 pid=2165 child_comm=ld-linux-x86-64 child_pid=2166 ld-linux-x86-64-2166 [019] .... 290.436398: handle_futex_death: 00007f066634e870: 876 -> 40000000 ld-linux-x86-64-2166 [019] .... 290.436399: handle_futex_death: 00007f066634e0c8: 876 -> 40000000 ld-linux-x86-64-2166 [019] .... 290.436400: handle_futex_death: 00007f066634ee38: 80000876 -> c0000000 ld-linux-x86-64-2166 [019] .... 290.436401: sched_process_exit: comm=ld-linux-x86-64 pid=2166 prio=120 ld-linux-x86-64-2164 [019] ...1 290.436546: attach_to_pi_owner: 2: 00007f066634e078 = 80000876 ld-linux-x86-64-2183 [026] .... 827.987914: sched_process_fork: comm=ld-linux-x86-64 pid=2183 child_comm=ld-linux-x86-64 child_pid=2187 ld-linux-x86-64-2187 [029] .... 828.188218: handle_futex_death: 00007f76dd361690: 88b -> 40000000 ld-linux-x86-64-2187 [029] .... 828.188219: handle_futex_death: 00007f76dd361898: 8000088b -> c0000000 ld-linux-x86-64-2187 [029] .... 828.188220: handle_futex_death: 00007f76dd3615c8: 8000088b -> c0000000 ld-linux-x86-64-2187 [029] .... 828.188220: handle_futex_death: 00007f76dd3612d0: 8000088b -> c0000000 ld-linux-x86-64-2187 [029] .... 828.188220: handle_futex_death: 00007f76dd361af0: 8000088b -> c0000000 ld-linux-x86-64-2187 [029] .... 828.188221: handle_futex_death: 00007f76dd361168: 8000088b -> c0000000 ld-linux-x86-64-2187 [029] .... 828.188222: sched_process_exit: comm=ld-linux-x86-64 pid=2187 prio=120 ld-linux-x86-64-2182 [019] ...1 828.188373: attach_to_pi_owner: 2: 00007f76dd361000 = 8000088b In both cases we fail in FUTEX_LOCK_PI trying to acquire a futex owned by a dead task, resulting in the -ESRCH. Now, pthread_mutex_lock() isn't expecting -ESRCH for robust futexes, because for robust we'd expect handle_futex_death() to clear out the futex value and set OWNER_DIED, as can be seen above. The problem is however that the futex address we fail on, doesn't appear to have been fixed up, so its either not on the robust list, or the robust list got broken. I'll see if I can narrow that down a little more.