From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Ganapathi Bhat <gbhat@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
<linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-wireless@vger.kernel.org,
Brian Norris <briannorris@chromium.org>
Subject: Re: [v3,1/2] mwifiex: initiate card-specific work atomically
Date: Thu, 18 May 2017 13:40:09 +0000 (UTC) [thread overview]
Message-ID: <20170518134009.8E38F60F5F@smtp.codeaurora.org> (raw)
In-Reply-To: <20170501193700.89264-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> The non-atomic test + set is a little awkward here, and it technically
> means we might double-schedule work unnecessarily. AFAICT, this is not
> really a problem, since the extra "work" will be a no-op (the flag(s)
> will be cleared by then), but it's still an anti-pattern.
>
> Rewrite this to use the atomic test_and_set_bit() helper instead.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2 patches applied to wireless-drivers-next.git, thanks.
21f569af9ab3 mwifiex: initiate card-specific work atomically
6d7d579a8243 mwifiex: pcie: add card_reset() support
--
https://patchwork.kernel.org/patch/9706851/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-05-18 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 19:36 [PATCH v3 1/2] " Brian Norris
2017-05-01 19:37 ` [PATCH v3 2/2] mwifiex: pcie: add card_reset() support Brian Norris
2017-05-01 19:38 ` Dmitry Torokhov
2017-05-01 19:38 ` [PATCH v3 1/2] mwifiex: initiate card-specific work atomically Dmitry Torokhov
2017-05-18 13:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518134009.8E38F60F5F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gbhat@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome