From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932252AbdESTf0 (ORCPT ); Fri, 19 May 2017 15:35:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56618 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbdESTfM (ORCPT ); Fri, 19 May 2017 15:35:12 -0400 Date: Fri, 19 May 2017 15:35:09 -0400 (EDT) Message-Id: <20170519.153509.2070245733064513776.davem@davemloft.net> To: peterz@infradead.org Cc: babu.moger@oracle.com, mingo@redhat.com, arnd@arndb.de, shannon.nelson@oracle.com, haakon.bugge@oracle.com, steven.sistare@oracle.com, vijay.ac.kumar@oracle.com, jane.chu@oracle.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC From: David Miller In-Reply-To: <20170519193126.vd52mhacekkhq342@hirez.programming.kicks-ass.net> References: <20170519090302.ph6jnqzlxxqzrvnu@hirez.programming.kicks-ass.net> <20170519.151553.928484900690074462.davem@davemloft.net> <20170519193126.vd52mhacekkhq342@hirez.programming.kicks-ass.net> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 19 May 2017 11:53:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra Date: Fri, 19 May 2017 21:31:26 +0200 > On Fri, May 19, 2017 at 03:15:53PM -0400, David Miller wrote: >> However, I don't see what any of this has to do with the feedback >> I was giving the patch author :-) > > Uhm,... I think my morning brain read things like you having doubts > about making it sparc64 only. But I could have easily misread things. > Ignore my ramblings :-) He was editing a sparc64-specific header, adding "queued locks" ifdefs, which makes no sense if for SPARC64 the queued locks will always be enabled.