From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478AbdESBPs (ORCPT ); Thu, 18 May 2017 21:15:48 -0400 Received: from mail-by2nam01on0072.outbound.protection.outlook.com ([104.47.34.72]:15104 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752301AbdESBPp (ORCPT ); Thu, 18 May 2017 21:15:45 -0400 Authentication-Results: spf=softfail (sender IP is 192.88.168.50) smtp.mailfrom=gmail.com; thalmeier.at; dkim=none (message not signed) header.d=none;thalmeier.at; dmarc=fail action=none header.from=gmail.com; Date: Fri, 19 May 2017 09:15:40 +0800 From: Peter Chen To: Michael Thalmeier CC: Peter Chen , Greg Kroah-Hartman , , , Subject: Re: [PATCH] usb: chipidea: debug: check before accessing ci_role Message-ID: <20170519011540.GB7460@b29397-desktop> References: <20170518141414.30798-1-michael.thalmeier@hale.at> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170518141414.30798-1-michael.thalmeier@hale.at> User-Agent: Mutt/1.5.24 (2015-08-30) X-EOPAttributedMessage: 0 X-Matching-Connectors: 131396301424094699;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39400400002)(39850400002)(39380400002)(39860400002)(39840400002)(39410400002)(39450400003)(2980300002)(189002)(199003)(24454002)(9170700003)(33716001)(76482006)(54356999)(229853002)(47776003)(105596002)(87572001)(305945005)(77096006)(106466001)(104016004)(8936002)(76176999)(46406003)(83322999)(82202002)(50986999)(6916009)(2950100002)(6666003)(5660300001)(97756001)(86362001)(9686003)(83506001)(4326008)(33656002)(189998001)(97736004)(54906002)(4001350100001)(55016002)(73392002)(6260500002)(6246003)(8656002)(73972006)(110136004)(2906002)(53936002)(81442002)(81166006)(38730400002)(356003)(1076002)(50466002)(23726003)(498600001)(8676002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB162;H:tx30smr01.am.freescale.net;FPR:;SPF:SoftFail;MLV:ovrnspm;MX:1;A:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD046;1:wXOmxR32sRxF1/dZYQMIkgnNnnI4jK/+vl5NaY28SYMWKJXXuqWcRW5JReXglPM5gvpDB2kaLaH/rg5Xdzz8u4yXdI+AD3i0hdwqew6UtVQyEV8vbY4fkMZRSsFIVwOb7qCb2WBDGuailCybR1XiJvXM22DxgvjObesgkSlW1Z0w3gUWq3CHlyTRv81Ywkv/Wb/Q+7hAJLvFio7ZCK3weaRabHsXXTWTEsou0xLNM1E1TXQ4oCCohzn1S6xc3iDFwvr6+iZBPVwxUCZBfl4HOKd2aYZqxs9U5FhfsxDUXYPpR0sNABuMJzsM9RX8vhJlJfOR0RxrUCxyAfDLjZCP5LGkqh+ly5TnuS6KA2+/qBQBkVwAQi1fJw4l2BSqbBjF1Iwmmc+N0jrD5/pnGazTQ1iwFnukz5q1WSxmqhmDSJdKN8QtzaHrGScwqwGaZ/os3GPab8bcPq9cviOSm6ba4wiCwISNfFsd5o8RYzNI8IhvNKB4A8sXrBxo/7qEMBZYDVnC32iL3pw7yvU9msavMciTOvllJJgK/xcJLee0nHcE1m7HAA8XNugeDlWIQUUqYwjdwyKhoPKq8mtZ0Hsyghnr9yZp0khqM91rdGeJoxs= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL2PR03MB162: X-MS-Office365-Filtering-Correlation-Id: f4c52544-7ba8-4c1d-8c8c-08d49e5491a3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BL2PR03MB162; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB162;3:M0KGtJgypgN8HISU8D8lBKDuvccSeCoIuAOnnqObJP9lBPYuXiRm2KsvyqD+t26ZjQpVemW7fItOApEmULSqn5Ulyjut4snC8WFFt+5dZWY5zvQZ5hEx3kFtRA7CLTVNi5+Zr+Zs4IHoaIrBFlGkLWEWwilUKXxdQ986hyJ7MXv5ciD+68fvutuqMmq8Lro+bpwbBrJ3kJQzgMAqNrHZNqO5GtR5kkEWuanFOWHTCVOZZ0wbbEe5kvg4LjniVTpI6Q21bdBhe0HSUSCpEZVJpoP0OAa0UFwigUp6d66rfY+4SLjHbm4ol9KvKbU2axyxJz+cdatVnpCsTbiAfJhsbBNRT/SzRZj7oP06pKFKcGkCyhkbH2jBMHXzJSYn/xk2md/Pqapxer5SUwJRur6mo3HsyVJ1TDzkF9lMfpMqY/ctnl0SVWc69b+sUqL/4ep9;25:+BSYDiZml7HHDjmtB2v3nKej2X7YHiKkcWDCUnPgqm9lxeS1iKgjj9dh1nhaDNHmZ4qx3HwJw3nGigPOSUopdXv/j4qMQqyjS3YFSmPm5IgcGuYCg45e3fIqzio7K+RZ1/WgGOCO7epgYsLFGikCH5HCFL1O0PL5FfCpW60a6HFTrUQXeSQCQxLcDNcdldo0hVk+xHjZeQSYQ73ND/3SQDNN/2TmXGrASoGOuZoi06FBG9TTgMogyMlFlReWML4mL30lQlgSl/RRm5Uk/RLUcgnUTVxXWXS72NZEYZ7e3ALFpOgUhxjcmFLvaiKO+O1Xh9F4SHCA8T6xuyBsSl1YNLuCKy/++20Q51mfJOhJfpp51+7kvnpVwy+0fguH/qJ0W+eXUuFcZ2EVno1ZKTyRIr6oNaV5SQzHKMPlB1ByBgy4aWtrsvDVRGl4KbUJla7itfenTz3boq9BoOmyvCWEhQq5Y1Edp+M9aOmj2+QTRCk= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB162;31:3ePwrDRboTVFrGdoAOIKdXX1xAa71o4onGHTQfhXY2ZbsjV2K2ieeT6a9zJR4XuV+KWawQ/X5QnU6cRsIjfPELpXXnzQZef45Q6Nfttahaa5gRGRZJyjKeI8euIl7Tft+htLL1ttlRaC2lhg8OV5GWKtxHmYtLFUt0/Z0Q3Ylus+xJcDNQx8ugC2vVJUSnsMRgo2S+KlY/asccxL0LFlAZyjStW/d648t/OzK4Sthx4/Gnp7qqLmEqTAC2o9wl3OwTeSoLx+Op/pF2M8cSrnfg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13018025)(8121501046)(13017025)(13015025)(5005006)(13024025)(13023025)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123556025)(20161123559100)(20161123565025)(20161123563025)(20161123561025);SRVR:BL2PR03MB162;BCL:0;PCL:0;RULEID:(400006);SRVR:BL2PR03MB162; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB162;4:TyrJxCrmgnTlFacMRo9JrrWSHceGLZy4x0cg+LwVpmlQfLa7b1tfC9O0P2MWJk1VgXfJ2moZbXG3bsR4VW8Mlx32OKs4Q0nNJPK5uTXvs7AVoSW5dEOTfjVqTUfw0Fx91kuBhallf5jQHeEsV2nMxgYKkXIvM/sTWdsd5FsBZ0QqR857Rf0JsDbicT0YhWybiEPlzyMP63pS2lwFyRT/RYvWscScITIezQMeCfk8YnIxWXFX8jhMwDBuR9/7KSzk7kMttIQkC17ZKx6Hz83AyjiDiGtZem76Qjx4ptO4KbK47ba1J32bV/ATOEtvLV3DGRGpIeHPutmmfg135OBgtniTwqyUv5Dz8au1kZVm5sV5n5OEu9nAkawcGARJaKmDxA4QbKpEG8kjQmfXidLDyF8yTuFL108UyRPuYvUJDDzdiwwKOjlG0eAAyDsL5NjNO9CYwhfNAu/f71ooalQNFd1FEXSUcVWi7tFjz2dN5ECjGavuzKHCB13F7rd1JQDfSBplFyOLmhdKuQZqoKnrfbgQQX9GJxWKROE4ecIPph1bbfps0BgeIAFEPkdhI0aeAn9SOaFXLiyhl+2UEckPnei8sdatUG2RNXz6AFHb8NnPGNFEklxpnqjJQqIPXnUNs1yZ4V3Vng4WhPsgfIeyglMqbAXRzRa/iDZpkeHZLoWOkB6YscaXm6LmkabCUgRP8E/t3wSi4BsHvxQQo4sK0GFU7r+QGz4K88+tdd+z3fzm4C5ZghWJb1CVmE1QN4zyx2yVJSLI4gZZtF7Y+Gd9YBgI5/RZ8WiROrvOVThTXKEedQ/Px+t6Yeib0iRhQt4ESb0arXOyNFjzQP8FsdLA7/c5v29JIeK+X7WHB1eR3V1CzQi2i/s50gOhGbYZ7la+1cShKNWUCZKGS9Ocp+vE8qUZVWUz4PsAd8DAjscMzz0= X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB162;23:7W/XAPjlKSQUxuLEAK/xySG9rA5iAk3vON0KkTc5KB?= =?us-ascii?Q?gJsO7v9nUgW6kYGs7DxBaJ5yYO2Qrf1UBcwtLj2ryBjQ4vS8qTnlMm8L0J3V?= =?us-ascii?Q?YJfBxYV0g9S3qi53peD3O0+AV9PGuX58yc+PCQAyNi2rsR3UirGPql+ZZWZ9?= =?us-ascii?Q?vMqSo4Aqy1qomN9epa4unKLGbJJY5OXD4E+Kxi8DOOEjP4Gly/R5uTGrPYA3?= =?us-ascii?Q?qNwHXxBBIs/NpBy3VB66ScSWgnsrNAhEcJB2oHKRyMcT/3GA2kbxQpfbEz3b?= =?us-ascii?Q?Lq7aJ8mbnzBXUIzGOGaTgMhLFbMjjrGEuBIJCKnJeCKuqlM8YOndZACGQt+w?= =?us-ascii?Q?LaaRu/0saUNexA0V2a6zlC4L1mBWL4SEyLWvqRUqd5lT3jM/owIc2IR0zzup?= =?us-ascii?Q?LXtJG6Ldo4A+5My4nnyf0NJ+VVm7PJ5D5eapsZpKG21/Z0l16Z96l0kW0zDj?= =?us-ascii?Q?xKgYzYcA8byvHtNDGS5mQ/61yuSM1zhmh3SJuz7x0cgsWBb2QotQ870nFYvI?= =?us-ascii?Q?uMyvG4m+cqqOHbRa4jqLsRwltvYKiNmcW0tYnDKSFRvZNOAOhpPYVv+MOlkE?= =?us-ascii?Q?WHwqok62mDRxeUvbOfO8PrsM7VUwoh7UDm5dIjMIVR/xn/vb3GOBrGtAxalF?= =?us-ascii?Q?HHepsLTEnsoqLg3a5wi9kR2Pd2X3e8T4HYeDvTNMiMxrZq0jRA3yzvsrmg6F?= =?us-ascii?Q?rEPaRtKAqy4L7OVJxSUBe+mnOWWqSdaXpfM5YYHIi4rLGFr5yw4kH7MVAHIQ?= =?us-ascii?Q?nxwegwucMvaEh4a2NVfrw0GjUD2BrixAmxpSWuefInWTHCPNcYaD+7Y92BKF?= =?us-ascii?Q?wC6zLPquwUtiT70ZkMBWRFtxP9yqZOWf5IHs0rPt+G9BTF2MxGurz+YOI+QE?= =?us-ascii?Q?GGDe3FAgC8e366CtYihak3f8avZlGIDpIsfLOJSFDONAi6Uov6jBf+OuC4aJ?= =?us-ascii?Q?0HqDsEL3jVgmAcJSSsRIgWo5etUdeeYVzBN4E+2MAcJ28DioG6jI3yc+KUqX?= =?us-ascii?Q?RKtgnlLAY0dG3hJlZoyCU+pc4mwSOxH+cl2oiQKbj4KXI3AxRYQVjYHUSReD?= =?us-ascii?Q?8Khv4i7Zu/JfbomEkNvqrPRDQWsrb8ugkm4F+XpXXurypGhKRPhzu1ydxQBo?= =?us-ascii?Q?TDJT31JAh4zzGCoDgCL08PEqa7Xvw28/6rN5raNqGf+TLU1Uya/BXqN4hQdu?= =?us-ascii?Q?oNGaTf9z0Rm0/J1hiku85vi3gRsLi0OMZ/gg6rgT20eimIRT/n+ycKmoEYCX?= =?us-ascii?Q?N0HvzG5TnulAPqVYDcXWJrCZZxw0GKIIzuWS8jSaH1wengC70r07mHGd9RKM?= =?us-ascii?Q?lvBz43y/sgsb6+fiunlvPHC9G0GBFjIxWujhBvUGD9DTFD92H3g9f7T/XB7p?= =?us-ascii?Q?Rh/WCbFxF+Vw4y3K12wbP6Bw3m8fgTm8+t/UGY2okkLtOhWvZ21kaje8TPks?= =?us-ascii?Q?WnNkjHP3y1FUv8gpORl8yAz2lJCsdf9PCckYHuBwj/QZee4hK2qw98lzKDxm?= =?us-ascii?Q?Zl1CushgKn44ISSnKnztICUuJFj6/7XNjjfEN5Fsmv7T0fqjnd3zV6f7lrSs?= =?us-ascii?Q?dgRMoDNidnJQTVsw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB162;6:40Xcf1IitU8Tz2cep3tigB2pX1SkiRSNKB3cDwjxQfPRUDUXUXbbO5kYNwTPNB3WCLBJ7bGIWi1UmTZWvrFn/IFmUd/36P/l77USuHtv78bwgHc54zlJihHKdb6zPZfXABK5jNbL4zguidgmotam9tMTvsA/Al0OYBh5EqurOO4jrsmlUK/Z0vSztehH8ZZxpvMRvdCTKzVLEphRZSaPU11WGg0Mr0d1C7/ibc9BwN3XAwqTe2Pa5JbMUKxGy3TDoD1eNhq/uBgEISu2X31YSPdmqRCzRdDa8JKB39tkiT+F0oPoKRA+xpiPZ0chmQo6U4d4AOsfLnDLcFp0qwGtsrcyfk5JosU2+XOFPd6uYkx4squaq4rYgZwF5KIYslvII7ld96+KmoQnA4pcy5YzofK27hsn6wnx0cRX1KZndKzGvNbyV42SmzQDv2eoAXdYAjHvU/i8rSJ6Fs7GEyXa3+d/EPSE9lTwsOuIM19UngQy18FQmC/Enwu1xF+gl9MZ2/G0/WiC4FtOLVGp0uTcVw==;5:pRO2uHAJWqFFKWoFV+dhrhtVxLIW59Gy2RsBlM9PIz1CwZUJ3sippqGirj9/Rjt0jBMhC1GOG83ZBX9j/wLXqQbIxtE3cY2yzhAuoHnotCe86aiawF8P2xOBAiExZj2gixj7pn6Vp/PGM8zVvhLtF/bVnmntB7lUsahLhY6TGCqbUgJSK+S7V+7kvEWE/JIk;24:Ui8dhh8dEGz/7C8QwZfKjoRehBYzob1ubrfNFBekUqUFSNjCg6QFeFoo1V1T8iAh3xDBZRrqLTMCRO1NEt3mCE5sWlRFHhKMnD7S5QH2ynA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB162;7:zb4RNOKbgWBM0YZaJNsNmv2wYeo5kZFldXeUbTbWcfaeyzt56l3wDNBbkkF0rbD4NGd2BTfMSibE30LLcsuecB8S3Za0p2O+EZzqoT82ITxGcxvlM1gn7gmIXXhVqcyB2LZP8EezeBEDcmuOkZ/yqgGZEKxWBJ1F5AamDCEVfdja1G4Zq7HflD2eV5ZReyUePQkR20HlpTpyFkcJF8DiN+iistFvW6kVOMKuxq9Iq0Gdhp/0c4qjYOsqU/cGeB9DbDrdRQaIbKIituJaItEKevetq83vMkc/GDyQqyVY0owUBfFNc8foDOhYzR1SJUiZp/eZs6cnBu1NHUSZpj51HQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 01:15:42.2222 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB162 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote: > ci_role BUGs when the role is >= CI_ROLE_END. > > Signed-off-by: Michael Thalmeier > --- > drivers/usb/chipidea/debug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > index 6d23eed..1c31e8a 100644 > --- a/drivers/usb/chipidea/debug.c > +++ b/drivers/usb/chipidea/debug.c > @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data) > { > struct ci_hdrc *ci = s->private; > > - seq_printf(s, "%s\n", ci_role(ci)->name); > + if (ci->role != CI_ROLE_END) > + seq_printf(s, "%s\n", ci_role(ci)->name); > > return 0; > } By the way, how can you trigger this issue? Do you mind sending another patch to fix the same issue for ci_role_show at core.c? -- Best Regards, Peter Chen