From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756266AbdESDml (ORCPT ); Thu, 18 May 2017 23:42:41 -0400 Received: from mail-pg0-f49.google.com ([74.125.83.49]:33085 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215AbdESDkL (ORCPT ); Thu, 18 May 2017 23:40:11 -0400 Date: Fri, 19 May 2017 09:10:07 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, Linux Kernel Mailing List Subject: Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused Message-ID: <20170519034007.GJ17481@vireshk-i7> References: <20170518132834.1744968-1-arnd@arndb.de> <20170518141800.GI17481@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-05-17, 16:51, Arnd Bergmann wrote: > I find that a lot of users get the #ifdef wrong, either using the wrong > macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right > set of functions (e.g. calling a function only from the suspend handler). > > The __maybe_unused annotation avoids both problems and also gives > better build time coverage, so that's what I tend to use. Thanks for the explanation Arnd. I hope these unused routines will not be part of the binary that gets generated. Right? Reviewed-by: Viresh Kumar -- viresh