From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Daniel Thompson <daniel.thompson@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chris Metcalf <cmetcalf@ezchip.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available
Date: Fri, 19 May 2017 13:38:15 +0900 [thread overview]
Message-ID: <20170519043815.GB593@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170519025803.GA593@jagdpanzerIV.localdomain>
On (05/19/17 11:58), Sergey Senozhatsky wrote:
> > void printk_nmi_exit(void)
> > {
> > - this_cpu_and(printk_context, ~PRINTK_NMI_CONTEXT_MASK);
> > + this_cpu_and(printk_context,
> > + ~(PRINTK_NMI_CONTEXT_MASK ||
> > + PRINTK_NMI_DEFERRED_CONTEXT_MASK));
> > }
[..]
> the problem is that
>
> `PRINTK_NMI_CONTEXT_MASK || PRINTK_NMI_DEFERRED_CONTEXT_MASK' is 0x01
d'oh... forgot to copy-paste this...
---
diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c
index 6fec9cfb9a69..b6ff3fe4370a 100644
--- a/kernel/printk/printk_safe.c
+++ b/kernel/printk/printk_safe.c
@@ -324,7 +324,7 @@ void printk_nmi_enter(void)
void printk_nmi_exit(void)
{
this_cpu_and(printk_context,
- ~(PRINTK_NMI_CONTEXT_MASK ||
+ ~(PRINTK_NMI_CONTEXT_MASK |
PRINTK_NMI_DEFERRED_CONTEXT_MASK));
}
---
-ss
next prev parent reply other threads:[~2017-05-19 4:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 15:46 Petr Mladek
2017-05-05 2:21 ` Sergey Senozhatsky
2017-05-17 15:08 ` Petr Mladek
2017-05-19 2:58 ` Sergey Senozhatsky
2017-05-19 4:38 ` Sergey Senozhatsky [this message]
2017-05-19 13:02 ` Petr Mladek
2017-05-20 9:04 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519043815.GB593@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@ezchip.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®