From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbdESHT0 (ORCPT ); Fri, 19 May 2017 03:19:26 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44347 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbdESHTY (ORCPT ); Fri, 19 May 2017 03:19:24 -0400 Date: Fri, 19 May 2017 09:19:22 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel , devicetree , linux-arm-kernel , linux-sunxi Subject: Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64 Message-ID: <20170519071922.awmib4qphl6ac6mj@flea.home> References: <20170518071653.36561-1-icenowy@aosc.io> <20170518071653.36561-10-icenowy@aosc.io> <79B00D42-3F95-4D5E-9A23-8E893CCF2462@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tafftxaun7gqred4" Content-Disposition: inline In-Reply-To: <79B00D42-3F95-4D5E-9A23-8E893CCF2462@aosc.io> User-Agent: NeoMutt/20170428 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tafftxaun7gqred4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 19, 2017 at 11:03:33AM +0800, Icenowy Zheng wrote: > >The patch looks OK, but given the module is removable, I think it > >should be > >an overlay. The overlay would enable WiFi + Bluetooth, and all the > >peripherals needed to connect them. > > > >That way, if the module is not installed, we avoid confusing the user > >with > >unused peripherals, and avoid having live voltage on an unoccupied > >header. >=20 > But as this header have specific usage, we will also confuse user > if it's not enabled as its target usage. Yet you would enable unused resources. This was already pointed out here: https://patchwork.kernel.org/patch/9670235/ Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --tafftxaun7gqred4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZHpx6AAoJEBx+YmzsjxAgalAP/0j+8+GX9lyGUpR7pDsLEv8q JF+fphFq4U8hoIT2ujJxk+qwTHUYLYiz+DJ/0ctej1XLCWQoeLzx1QLC6tdvdix+ uJ4g5g55OnhuIF7v1OCYyLqyESAM0wBLT40LW3+Ii3aD6I39xA13lCwLmu8Jq0z3 BkEWIpdM0saIFXp6GJznUjMni9imP2kggcmnE7+THhf1j41dN9uZRSge/vVUwcVR alU0Rl9mfcRScwabbz3+PqiB+BdW4rlDHvCiZQWKuBdmm8jCFyXQXTozB1w5lF4d 2ex/yJHUiLSde2NGOqGNNLREv92P91RecJ8E7QFlHuYoWAa8Qv62CWMMk+IRypkt TuSSZXc63Tip6maq1ZSGMZYXFLBC3098sJVjvdC8ltMMIVXpKv7qaV6P1hw/ArPZ B1qboXQp3nFa1aY6ShpdryxjdvZO13vyT011DmzxYIEqn8HTk+Z5xcsd5RMw/7Yw UrSuXbRm5LwyLKjfBMAe+9zJZbOE/73yB8O/xC1l6c+HS85Yl5PZ0Zby5iw1z28t EdnkqjYbnGKdk6bQsSyqQlKbjclCj94FH7eaiEyFJyb5GDguhtudCdfC7GQ36rhU 3f3EknNSASKRaEs2WCzSsseTqjkGCbOPr4fGmuss9OURNtYJwWiLcyiwAoYSvAvD Gjl9W567FgysmufSCOf0 =TQNS -----END PGP SIGNATURE----- --tafftxaun7gqred4--