From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756154AbdESSET (ORCPT ); Fri, 19 May 2017 14:04:19 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:59579 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752891AbdESSCh (ORCPT ); Fri, 19 May 2017 14:02:37 -0400 Date: Fri, 19 May 2017 20:02:15 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Rob Herring , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [RFC PATCH 01/11] dt-bindings: update the binding for Allwinner H3 TVE support Message-ID: <20170519180215.7lc7duueu74pt4kz@flea.home> References: <20170517164354.16399-1-icenowy@aosc.io> <20170517164354.16399-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhwnzsjpz5kvdc7d" Content-Disposition: inline In-Reply-To: <20170517164354.16399-2-icenowy@aosc.io> User-Agent: NeoMutt/20170428 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zhwnzsjpz5kvdc7d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 18, 2017 at 12:43:44AM +0800, Icenowy Zheng wrote: > -On SoCs other than the A33 and V3s, there is one more clock required: > +For the following compatibles: > + * allwinner,sun5i-a13-tcon > + * allwinner,sun6i-a31-tcon > + * allwinner,sun6i-a31s-tcon > + * allwinner,sun8i-a33-tcon > + * allwinner,sun8i-v3s-tcon > +there is one more clock and one more property required: > + - clocks: > + - 'tcon-ch0': The clock driving the TCON channel 0 > + - clock-output-names: Name of the pixel clock created > + > +For the following compatibles: > + * allwinner,sun5i-a13-tcon > + * allwinner,sun6i-a31-tcon > + * allwinner,sun6i-a31s-tcon > + * allwinner,sun8i-h3-tcon0 > +there is one more clock required: > - 'tcon-ch1': The clock driving the TCON channel 1 Putting ID's in the compatible name is usually a bad idea. What is the difference between the two? Only that the second one doesn't have a clock? That seems highly unlikely. How does it generate the pixel clock frequency? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --zhwnzsjpz5kvdc7d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZHzMnAAoJEBx+YmzsjxAghdkP/jMCKTu4ahssq/exK6mZLsvH V2VRotU/ZEa6xlA8XbwPZeq+XwzcNPGfvy8rF04xA5uyjp9UIig0Volhhg/R41l9 YWDVntRsJ9Z7DeadkC/5fx34D07t5YT9hNWYdCzYqhsgReB2q/SjwfLGB7ZanEg0 dL9h9hGfr2A+VHn0slwVoalR+VrIh+3VFC7ZJ5oV1juAQ4oNFMmEmzNDHnrlj1iT 9kRuwgoirGtOh9WR4NnpEobrHJF8W0OfgpTvS/gevUSJVkYWh9rtKDzEfDebLLqx SLZxe0FtR6XPVBSAFPkl6aP3Nq9zglIYrgE+YEFosi2njyh4g60JTXJejC5LSuZT FokK6izsHnkor93YZ05ubX7a7Et4M6Jxy1HPfuN8GZpf2ytrR04CGTLBLubKMdcr eADaEsROii6YS+M26vJ8A3z9QoQpxOVmUN49puSVU4KDPj+7CpLe1NPpbHQ8yq22 7RT035qqQXKXLDG211VC+gK6E/pI0mslCzTcbMJIGxG31YCxosOowY2s3zEVZ2Ej GuN7Up3iX3dJevW/hr/YHES8NrNsLBZFx3H6T/Ju8onS4LLMToMhweGIIiIGTNg2 UlZrJkPqIsPUENaQ+MqCXVO2z6H1urk5WYhX2xKnc4cQAzqcA8iJUWsikTxsLfTl WQGqP2xZjdIsou0Qjj5B =rBMI -----END PGP SIGNATURE----- --zhwnzsjpz5kvdc7d--