From: Matthias Kaehlcke <mka@chromium.org>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Subject: [PATCH v2] zlib: Mark get_unaligned16() as __maybe_unused
Date: Fri, 19 May 2017 11:10:16 -0700 [thread overview]
Message-ID: <20170519181016.17921-1-mka@chromium.org> (raw)
The function is not used with all configurations. Adding the attribute
fixes the following warning when building with clang and
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y:
lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
[-Werror,-Wunused-function]
get_unaligned16(const unsigned short *p)
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- explicitly include <linux/compiler.h> where __maybe_unused is defined
lib/zlib_inflate/inffast.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/zlib_inflate/inffast.c b/lib/zlib_inflate/inffast.c
index 2c13ecc5bb2c..bae26afdc565 100644
--- a/lib/zlib_inflate/inffast.c
+++ b/lib/zlib_inflate/inffast.c
@@ -3,6 +3,7 @@
* For conditions of distribution and use, see copyright notice in zlib.h
*/
+#include <linux/compiler.h>
#include <linux/zutil.h>
#include "inftrees.h"
#include "inflate.h"
@@ -27,7 +28,7 @@ union uu {
};
/* Endian independed version */
-static inline unsigned short
+static inline unsigned short __maybe_unused
get_unaligned16(const unsigned short *p)
{
union uu mm;
--
2.13.0.303.g4ebf302169-goog
next reply other threads:[~2017-05-19 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 18:10 Matthias Kaehlcke [this message]
2017-05-22 8:57 ` kbuild test robot
2017-05-22 18:27 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519181016.17921-1-mka@chromium.org \
--to=mka@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®