From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbdESTeh (ORCPT ); Fri, 19 May 2017 15:34:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41800 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbdESTeg (ORCPT ); Fri, 19 May 2017 15:34:36 -0400 Date: Fri, 19 May 2017 22:33:33 +0300 From: Dan Carpenter To: srishti sharma Cc: Greg KH , devel@driverdev.osuosl.org, Florian Fainelli , sbranden@broadcom.com, Stephen Warren , rjui@broadcom.com, lee@kernel.org, Victor Vaschenko , linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, mzoran@crowfest.net, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue Message-ID: <20170519193333.5sfsripy27k3xd7r@mwanda> References: <1495104615-4752-1-git-send-email-srishtishar@gmail.com> <20170518135850.GA24513@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: > Was the format of this patch acceptable ,the "from" matches the > "signed-off-by" right , so this should be correct , were there any > errors in this ? Should I resend it ? > > Regards, > Srishti > You should capitalize your name in both since you're doing that here. Also I really think you can figure out how to fix your email headers so you don't need to use a From header. Lots of people use gmail and they were able to figure it out. But yeah, the way you sent it is also fine. regards, dan carpenter