From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756373AbdESUCz (ORCPT ); Fri, 19 May 2017 16:02:55 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:32768 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbdESUCw (ORCPT ); Fri, 19 May 2017 16:02:52 -0400 From: Matthias Kaehlcke To: Dan Williams , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke Subject: [PATCH] dmaengine: pl330: Mark unused functions as __maybe_unused Date: Fri, 19 May 2017 13:02:26 -0700 Message-Id: <20170519200226.85420-1-mka@chromium.org> X-Mailer: git-send-email 2.13.0.303.g4ebf302169-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Several functions are not used and probably kept around for completeness or debugging. Adding the attribute fixes a bunch of warnings like this when building with clang: drivers/dma/pl330.c:568:19: error: unused function '_emit_ADDH' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/dma/pl330.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 8b0da7fa520d..cb0852f24f19 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -538,7 +538,7 @@ struct _xfer_spec { struct dma_pl330_desc *desc; }; -static inline bool _queue_empty(struct pl330_thread *thrd) +static inline bool __maybe_unused _queue_empty(struct pl330_thread *thrd) { return thrd->req[0].desc == NULL && thrd->req[1].desc == NULL; } @@ -564,7 +564,7 @@ static inline u32 get_revision(u32 periph_id) return (periph_id >> PERIPH_REV_SHIFT) & PERIPH_REV_MASK; } -static inline u32 _emit_ADDH(unsigned dry_run, u8 buf[], +static inline u32 __maybe_unused _emit_ADDH(unsigned dry_run, u8 buf[], enum pl330_dst da, u16 val) { if (dry_run) @@ -738,7 +738,7 @@ static inline u32 _emit_MOV(unsigned dry_run, u8 buf[], return SZ_DMAMOV; } -static inline u32 _emit_NOP(unsigned dry_run, u8 buf[]) +static inline u32 __maybe_unused _emit_NOP(unsigned dry_run, u8 buf[]) { if (dry_run) return SZ_DMANOP; @@ -778,7 +778,8 @@ static inline u32 _emit_SEV(unsigned dry_run, u8 buf[], u8 ev) return SZ_DMASEV; } -static inline u32 _emit_ST(unsigned dry_run, u8 buf[], enum pl330_cond cond) +static inline u32 _emit_ST(unsigned dry_run, u8 buf[], + enum pl330_cond cond) { if (dry_run) return SZ_DMAST; @@ -817,7 +818,7 @@ static inline u32 _emit_STP(unsigned dry_run, u8 buf[], return SZ_DMASTP; } -static inline u32 _emit_STZ(unsigned dry_run, u8 buf[]) +static inline u32 __maybe_unused _emit_STZ(unsigned dry_run, u8 buf[]) { if (dry_run) return SZ_DMASTZ; @@ -829,7 +830,7 @@ static inline u32 _emit_STZ(unsigned dry_run, u8 buf[]) return SZ_DMASTZ; } -static inline u32 _emit_WFE(unsigned dry_run, u8 buf[], u8 ev, +static inline u32 __maybe_unused _emit_WFE(unsigned dry_run, u8 buf[], u8 ev, unsigned invalidate) { if (dry_run) -- 2.13.0.303.g4ebf302169-goog