From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757107AbdESVB2 (ORCPT ); Fri, 19 May 2017 17:01:28 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35126 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756871AbdESVBU (ORCPT ); Fri, 19 May 2017 17:01:20 -0400 From: Matthias Kaehlcke To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke Subject: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems Date: Fri, 19 May 2017 14:00:34 -0700 Message-Id: <20170519210036.146880-2-mka@chromium.org> X-Mailer: git-send-email 2.13.0.303.g4ebf302169-goog In-Reply-To: <20170519210036.146880-1-mka@chromium.org> References: <20170519210036.146880-1-mka@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef block fixes the following warning when building with clang: mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- mm/slub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index 57e5156f02be..66e1046435b7 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1313,11 +1313,14 @@ static inline void dec_slabs_node(struct kmem_cache *s, int node, * Hooks for other subsystems that check memory allocations. In a typical * production configuration these hooks all should produce no code at all. */ + +#ifdef CONFIG_NUMA static inline void kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags) { kmemleak_alloc(ptr, size, 1, flags); kasan_kmalloc_large(ptr, size, flags); } +#endif static inline void kfree_hook(const void *x) { -- 2.13.0.303.g4ebf302169-goog