From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ed L. Cashin" <ed.cashin@acm.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] aoe: harmless underflow in minor_get_static()
Date: Sat, 20 May 2017 00:28:48 +0300 [thread overview]
Message-ID: <20170519212848.xba4nc2zvr5xcjxg@mwanda> (raw)
The "aoemin" comes from revalidate() in drivers/block/aoe/aoechr.c. It
can be negative. We cap the upper bound but not the lower bound so
that's an underflow bug. But it doesn't matter because we check "n"
against N_DEVS so it all works out fine in the end.
Anyway, let's silence the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index ffd1947500c6..eddd0ecc9e0b 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -58,7 +58,7 @@ minor_get_dyn(ulong *sysminor)
}
static int
-minor_get_static(ulong *sysminor, ulong aoemaj, int aoemin)
+minor_get_static(ulong *sysminor, ulong aoemaj, unsigned int aoemin)
{
ulong flags;
ulong n;
reply other threads:[~2017-05-19 21:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519212848.xba4nc2zvr5xcjxg@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ed.cashin@acm.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®