From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756059AbdETQxu (ORCPT <rfc822;w@1wt.eu>);
        Sat, 20 May 2017 12:53:50 -0400
Received: from verein.lst.de ([213.95.11.211]:40979 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752207AbdETQxr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 May 2017 12:53:47 -0400
Date: Sat, 20 May 2017 18:53:45 +0200
From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Steven Rostedt <rostedt@goodmis.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: [REGRESSION] Failed network caused by: xhci: switch to
        pci_alloc_irq_vectors
Message-ID: <20170520165345.GA26850@lst.de>
References: <20170518234234.29127245@gandalf.local.home> <20170519054223.GA5954@kroah.com> <20170519060856.57cf2b76@gandalf.local.home> <20170519083721.5a415dc3@gandalf.local.home> <20170519124625.GA20063@lst.de> <CA+55aFyZMsXR7n194a7+vR-VgtfTVUcGOMmAuXJWDhGBekum+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFyZMsXR7n194a7+vR-VgtfTVUcGOMmAuXJWDhGBekum+Q@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 20, 2017 at 09:49:56AM -0700, Linus Torvalds wrote:
> Side note: why is it doing that " > 1" check, when any value _other_
> than 1 is wrong?

It's the same effect, so either one is fine with me.

> Also, to match the non-MSI implementation, wouldn't it be nicer to
> just write it that same way (and also verify "dev->irq"):
> 
>         if (flags & PCI_IRQ_LEGACY) {
>                 if (min_vecs == 1 && dev->irq)
>                         return 1;
>         }
>         return -ENOSPC;
> 
> (the exact error value probably doesn't matter in practice, but the
> CONFIG_MSI case returns ENOSPC by default and that's what
> Documentation/PCI/MSI-HOWTO.txt says too).

Sure.  Just sent the previous version to Bjorn so that he could maybe
make it for -rc2, but I'll respin it.