From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755227AbdETROt (ORCPT ); Sat, 20 May 2017 13:14:49 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32994 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbdETROq (ORCPT ); Sat, 20 May 2017 13:14:46 -0400 Date: Sat, 20 May 2017 19:14:42 +0200 From: Krzysztof Kozlowski To: Linus Walleij Cc: Tomasz Figa , Sylwester Nawrocki , Kukjin Kim , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-gpio@vger.kernel.org" , Chanwoo Choi , Marek Szyprowski , Alim Akhtar , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 Message-ID: <20170520171442.scgss76fbawsmhjd@kozik-lap> References: <20170516200649.4730-1-krzk@kernel.org> <20170516200649.4730-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2017 at 07:12:13PM +0200, Linus Walleij wrote: > On Tue, May 16, 2017 at 10:06 PM, Krzysztof Kozlowski wrote: > > > Exynos pinctrl drivers contain pretty big per-SoC data structures. The > > pinctrl-exynos object file contained code and data for both ARMv7 and > > ARMv8 SoCs thus it grew big. There will not be a shared image between > > ARMv7 and ARMv8 so there is no need to combine all of this into one > > driver. > > > > Splitting the data allows to make it more granular (e.g. code related to > > ARMv8 Exynos is self-contained), slightly speed up the compilation and > > reduce the effective size of compiled kernel. > > > > The common data structures and functions reside still in existing > > pinctrl-exynos.c. Only the SoC-specific parts were moved out to new > > files. Except marking few functions non-static and adding them to > > header, there were no functional changes in the code. > > > > Signed-off-by: Krzysztof Kozlowski > > Acked-by: Linus Walleij > I guess I will get this from you with a pull request? Yes, I'll send it to you with pull request. Best regards, Krzysztof