From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbdEUHoD (ORCPT ); Sun, 21 May 2017 03:44:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54602 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdEUHoC (ORCPT ); Sun, 21 May 2017 03:44:02 -0400 Date: Sun, 21 May 2017 09:43:50 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Okash Khawaja , devel@driverdev.osuosl.org, Kirk Reiser , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Jiri Slaby , Samuel Thibault , Alan Cox , Chris Brannon Subject: Re: [patch v2 1/6] tty: export tty_open_by_driver Message-ID: <20170521074350.GB3962@kroah.com> References: <20170515174531.968330974@gmail.com> <20170515175611.655323933@gmail.com> <20170521060902.GA32641@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170521060902.GA32641@infradead.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2017 at 11:09:02PM -0700, Christoph Hellwig wrote: > On Mon, May 15, 2017 at 06:45:32PM +0100, Okash Khawaja wrote: > > This exports tty_open_by_driver so that it can be called from other places inside the kernel. The checks for null file pointer are based on Alan Cox's patch here: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1215095.html. Description below is quoted from it: > > Any non-staging users? Please don't add new APIs with proper in-kernel > users (and staging doesn't count for that). I'll give the speakup code a pass here, as they are trying to get this cleaned up properly and moved into the correct location. It's almost ready, with this and the serdev interface, it should be pretty close... thanks, greg k-h