From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934945AbdEVOiK (ORCPT ); Mon, 22 May 2017 10:38:10 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52524 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934920AbdEVOiI (ORCPT ); Mon, 22 May 2017 10:38:08 -0400 Date: Mon, 22 May 2017 10:38:00 -0400 (EDT) Message-Id: <20170522.103800.1354089494827582585.davem@davemloft.net> To: garsilva@embeddedor.com Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel: bpf: remove dead code From: David Miller In-Reply-To: <20170522140746.GA10113@embeddedgus> References: <20170522140746.GA10113@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 May 2017 06:56:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Mon, 22 May 2017 09:07:46 -0500 > Execution cannot reach NET_IP_ALIGN inside the following statement: > ip_align = strict ? 2 : NET_IP_ALIGN > > Addresses-Coverity-ID: 1409762 > Signed-off-by: Gustavo A. R. Silva > --- > NOTE: variable ip_align could also be removed and use value 2 directly. Incorrect. Some platforms define NET_IP_ALIGN to zero, so the code must remain as is.