From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934949AbdEVSXS (ORCPT ); Mon, 22 May 2017 14:23:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933496AbdEVSXN (ORCPT ); Mon, 22 May 2017 14:23:13 -0400 Date: Mon, 22 May 2017 14:23:11 -0400 (EDT) Message-Id: <20170522.142311.1866840567813370892.davem@davemloft.net> To: jan.kiszka@siemens.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing From: David Miller In-Reply-To: <16d9bbf6-0579-f16c-4177-251fa3837a2a@siemens.com> References: <20170522.123555.2260863464877381826.davem@davemloft.net> <16d9bbf6-0579-f16c-4177-251fa3837a2a@siemens.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 May 2017 10:41:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4MINYVw017467 From: Jan Kiszka Date: Mon, 22 May 2017 19:06:07 +0200 > On 2017-05-22 18:35, David Miller wrote: >> From: Jan Kiszka >> Date: Mon, 22 May 2017 13:12:06 +0200 >> >>> Some cleanups of the way we probe DMI platforms in the driver. Reduces >>> a bit of open-coding and makes the logic easier reusable for any >>> potential DMI platform != Quark. >>> >>> Tested on IOT2000 and Galileo Gen2. >> >> This doesn't compile: >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: error: initializer element is not computable at load time >> (kernel_ulong_t)&stmmac_default_setup, >> ^ >> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: note: (near initialization for Ħstmmac_id_table[0].class˘) >> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: error: initializer element is not computable at load time >> (kernel_ulong_t)&stmmac_default_setup, >> ^ >> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: note: (near initialization for Ħstmmac_id_table[1].class˘) >> scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o' failed >> make[5]: *** [drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o] Error 1 >> > > Hmm. Which arch is this? x86_64, allmodconfig