From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760840AbdEVSix (ORCPT ); Mon, 22 May 2017 14:38:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54992 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760729AbdEVSis (ORCPT ); Mon, 22 May 2017 14:38:48 -0400 Date: Mon, 22 May 2017 14:38:46 -0400 (EDT) Message-Id: <20170522.143846.1648727051789760165.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, maheshb@google.com, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] bonding: fix randomly populated arp target array From: David Miller In-Reply-To: <20170519184646.42572-1-jarod@redhat.com> References: <20170519184646.42572-1-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 May 2017 10:57:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Fri, 19 May 2017 14:46:46 -0400 > In commit dc9c4d0fe023, the arp_target array moved from a static global > to a local variable. By the nature of static globals, the array used to > be initialized to all 0. At present, it's full of random data, which > that gets interpreted as arp_target values, when none have actually been > specified. Systems end up booting with spew along these lines: ... > None of these were actually specified as ARP targets, and the driver does > seem to clean up the mess okay, but it's rather noisy and confusing, leaks > values to userspace, and the 255.255.255.255 spew shows up even when debug > prints are disabled. > > The fix: just zero out arp_target at init time. > > While we're in here, init arp_all_targets_value in the right place. > > Fixes: dc9c4d0fe023 ("bonding: reduce scope of some global variables") > CC: Mahesh Bandewar > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > CC: netdev@vger.kernel.org > CC: stable@vger.kernel.org > Signed-off-by: Jarod Wilson Whoops... applied, thanks Jarod.