From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932816AbdEVCsS (ORCPT ); Sun, 21 May 2017 22:48:18 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33154 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbdEVCsO (ORCPT ); Sun, 21 May 2017 22:48:14 -0400 Date: Mon, 22 May 2017 11:48:16 +0900 From: Sergey Senozhatsky To: Nicolas Iooss Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] printk: add __printf attributes to internal functions Message-ID: <20170522024616.GA4469@jagdpanzerIV.localdomain> References: <20170520091853.26643-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170520091853.26643-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/20/17 11:18), Nicolas Iooss wrote: > When compiling with -Wsuggest-attribute=format, gcc complains that some > functions in kernel/printk/printk_safe.c transmit their argument to > printf-like functions without having a printf attribute. Silence these > warnings by adding relevant __printf attributes. > > Signed-off-by: Nicolas Iooss no objections from my side. Reviewed-by: Sergey Senozhatsky -ss