From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdEVH4O (ORCPT ); Mon, 22 May 2017 03:56:14 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:32923 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbdEVH4J (ORCPT ); Mon, 22 May 2017 03:56:09 -0400 Date: Mon, 22 May 2017 09:56:00 +0200 From: Daniel Vetter To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Dave Airlie , Andrzej Hajda , Archit Taneja , Laurent Pinchart Subject: Re: [PATCH v4 00/10] Introduce new mode validation callbacks Message-ID: <20170522075559.4papnrsq3olucrxw@phenom.ffwll.local> Mail-Followup-To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Dave Airlie , Andrzej Hajda , Archit Taneja , Laurent Pinchart References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentation a little bit. This > patch is available at [2] and the series depends on it. > > We proceed by introducing new helpers to call this new callbacks > at 1/10. > > At 2/10 a helper function is introduced that calls all mode_valid() > from a set of bridges. > > Next, at 3/10 we modify the connector probe helper so that only modes > which are supported by a given bridge+encoder+crtc combination are > probbed. > > At 4/10 we call all the mode_valid() callbacks for a given pipeline, > except the connector->mode_valid one, so that the mode is validated. > This is done before calling mode_fixup(). > > Finally, from 5/10 to 10/10 we use the new callbacks in drivers that > can implement it. > > [1] https://patchwork.kernel.org/patch/9702233/ > [2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html > > Jose Abreu (10): > drm: Add drm_{crtc/encoder/connector}_mode_valid() > drm: Introduce drm_bridge_mode_valid() > drm: Use new mode_valid() helpers in connector probe helper > drm: Use mode_valid() in atomic modeset > drm: arc: Use crtc->mode_valid() callback > drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback > drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback > drm/arm: malidp: Use crtc->mode_valid() callback > drm/atmel-hlcdc: Use crtc->mode_valid() callback > drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Looks all real nice, I think a bit more time to get acks/reviews/tested-by for the driver conversions and I'll go and vacuum this all up. Thanks a lot for doing this. -Daniel > > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja > Cc: Laurent Pinchart > > drivers/gpu/drm/arc/arcpgu_crtc.c | 29 ++++--- > drivers/gpu/drm/arm/malidp_crtc.c | 11 ++- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 +-- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++------- > drivers/gpu/drm/drm_atomic_helper.c | 76 +++++++++++++++++- > drivers/gpu/drm/drm_bridge.c | 33 ++++++++ > drivers/gpu/drm/drm_crtc_helper_internal.h | 13 +++ > drivers/gpu/drm/drm_probe_helper.c | 105 ++++++++++++++++++++++++- > drivers/gpu/drm/imx/dw_hdmi-imx.c | 4 +- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 2 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- > drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++- > drivers/gpu/drm/vc4/vc4_dpi.c | 13 ++- > include/drm/bridge/dw_hdmi.h | 2 +- > include/drm/drm_bridge.h | 2 + > 16 files changed, 280 insertions(+), 87 deletions(-) > > -- > 1.9.1 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch