From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758090AbdEVJgg (ORCPT ); Mon, 22 May 2017 05:36:36 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38311 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757390AbdEVJgf (ORCPT ); Mon, 22 May 2017 05:36:35 -0400 Date: Mon, 22 May 2017 10:36:31 +0100 From: Lee Jones To: Jan Kiszka Cc: Andy Shevchenko , Linux Kernel Mailing List Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Message-ID: <20170522093631.ij7bwscdvgupi6a5@dell> References: <80e73378-83d9-b61e-670d-6cd7372171c2@siemens.com> <1494329692.30052.75.camel@linux.intel.com> <20170512081209.2xvq7gtvl54dxl6b@dell> <7dbd8673-32af-f5ec-5ed5-c37ea87f7487@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7dbd8673-32af-f5ec-5ed5-c37ea87f7487@siemens.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May 2017, Jan Kiszka wrote: > On 2017-05-12 10:12, Lee Jones wrote: > > On Tue, 09 May 2017, Andy Shevchenko wrote: > > > >> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote: > >>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares > >>> its I2C frequency. > >>> > >>> Signed-off-by: Jan Kiszka > >> > >>> Signed-off-by: Sascha Weisenberger > >> > >> Hmm... I thought that SoB chain goes from first author to last. (Or in > >> case of maintainer / submitter their SoB goes at the end, which is > >> apparently not the case here). > > > > Yes, that's correct. I will switch them when I apply the patch. > > Apparently, the patch is not yet in mfd-next, so let me retract it: I > just realized we should rather do an exact name/asset-tags match here as > well (like for exar and stmmac). Consider it done. > Moreover, I'd like to rework the DMI matching along Andy's suggestion > and use native matching methods (dmi_system_id table) instead of the > current open-code one. Patches will follow soon. > > Jan > > > > >> Other than above > >> > >> Reviewed-by: Andy Shevchenko > > > >>> > >>> --- > >>> drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c > >>> b/drivers/mfd/intel_quark_i2c_gpio.c > >>> index 7946d6e38b87..98dddf2831ad 100644 > >>> --- a/drivers/mfd/intel_quark_i2c_gpio.c > >>> +++ b/drivers/mfd/intel_quark_i2c_gpio.c > >>> @@ -72,6 +72,10 @@ static const struct i2c_mode_info > >>> platform_i2c_mode_info[] = { > >>> .name = "GalileoGen2", > >>> .i2c_scl_freq = 400000, > >>> }, > >>> + { > >>> + .name = "SIMATIC IOT2000", > >>> + .i2c_scl_freq = 400000, > >>> + }, > >>> {} > >>> }; > >>> > >> > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog