From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932960AbdEVKks (ORCPT ); Mon, 22 May 2017 06:40:48 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:33614 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbdEVKko (ORCPT ); Mon, 22 May 2017 06:40:44 -0400 Date: Mon, 22 May 2017 16:10:40 +0530 From: Viresh Kumar To: Arvind Yadav Cc: vireshk@kernel.org, andriy.shevchenko@linux.intel.com, dan.j.williams@intel.com, vinod.koul@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] dmaengine: DW DMAC: Handle return value of clk_prepare_enable Message-ID: <20170522104040.GF6510@vireshk-i7> References: <1495449108-31532-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495449108-31532-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Create the patch using this command and the unnecessary "v1" in the subject will go away: $ git format-patch -C -M --thread=shallow On 22-05-17, 16:01, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/dma/dw/platform.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c > index c639c60..bc31fe8 100644 > --- a/drivers/dma/dw/platform.c > +++ b/drivers/dma/dw/platform.c > @@ -306,8 +306,12 @@ static int dw_resume_early(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct dw_dma_chip *chip = platform_get_drvdata(pdev); > + int ret; > + > + ret = clk_prepare_enable(chip->clk); > + if (ret) > + return ret; > > - clk_prepare_enable(chip->clk); > return dw_dma_enable(chip); > } You don't need to resend it for now. Acked-by: Viresh Kumar -- viresh