From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758687AbdEVKsN (ORCPT ); Mon, 22 May 2017 06:48:13 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36115 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757762AbdEVKsJ (ORCPT ); Mon, 22 May 2017 06:48:09 -0400 Date: Mon, 22 May 2017 11:48:05 +0100 From: Lee Jones To: Linus Walleij Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: ipaq-micro: dump debugging hexdumps Message-ID: <20170522104805.gkf5vcomwj3oyhll@dell> References: <20170515094405.12910-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170515094405.12910-1-linus.walleij@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 May 2017, Linus Walleij wrote: > These hexdumps get printed no matter if CONFIG_DEBUG is set or > not. Just get rid of them. > > Signed-off-by: Linus Walleij > --- > drivers/mfd/ipaq-micro.c | 5 ----- > 1 file changed, 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c > index 124aad2b1d02..cd762d08f116 100644 > --- a/drivers/mfd/ipaq-micro.c > +++ b/drivers/mfd/ipaq-micro.c > @@ -53,8 +53,6 @@ static void ipaq_micro_trigger_tx(struct ipaq_micro *micro) > tx->buf[bp++] = checksum; > tx->len = bp; > tx->index = 0; > - print_hex_dump_debug("data: ", DUMP_PREFIX_OFFSET, 16, 1, > - tx->buf, tx->len, true); > > /* Enable interrupt */ > val = readl(micro->base + UTCR3); > @@ -281,9 +279,6 @@ static void __init ipaq_micro_eeprom_dump(struct ipaq_micro *micro) > dev_info(micro->dev, "RAM size: %u KiB\n", ipaq_micro_to_u16(dump+92)); > dev_info(micro->dev, "screen: %u x %u\n", > ipaq_micro_to_u16(dump+94), ipaq_micro_to_u16(dump+96)); > - print_hex_dump_debug("eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, > - dump, 256, true); > - > } > > static void micro_tx_chars(struct ipaq_micro *micro) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog