From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] MAINTAINERS: Update MAX77802 PMIC entry
Date: Mon, 22 May 2017 13:06:48 +0100 [thread overview]
Message-ID: <20170522120648.zfgf25d7senf3ny2@sirena.org.uk> (raw)
In-Reply-To: <20170522110604.g66mzwhkum4v6eyp@dell>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On Mon, May 22, 2017 at 12:06:04PM +0100, Lee Jones wrote:
> On Tue, 16 May 2017, Mark Brown wrote:
> > > It's commonplace for me to provide Acks for patches I know will
> > > *eventually* be applied by me. Removing them when applying patches is
> > > part of my daily routine.
> > You're the only person I'm aware of who does this.
> The operative words here are "I'm aware". Conversely, I know lots of
> Maintainers who do this, but I guess that comes with the territory
> when dealing with the types of patch-sets that I handle. Often times
Interesting... any examples? I get quite a bit of this as well as a
result of regmap and regulator and I can't say it's ever come up.
> > > TL;DR: If a Maintainer (or anyone for that matter) provides a *-by
> > > tag, it should be carried forward with the (unchanged) patch until
> > > acceptance.
> > Given what acks get used for (they're more of a process thing than
> > anything else) I'm not so sure it works well for them.
> I'm not entirely sure what is meant by this.
An ack is basically a step down from a review saying "I'm OK with this
being applied" but not actually "I did a thorough review". That makes
it a bit funny compared to a review, testing or similar.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2017-05-22 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 4:36 Javier Martinez Canillas
2017-05-14 9:52 ` Mark Brown
2017-05-16 7:51 ` Lee Jones
2017-05-16 11:06 ` Mark Brown
2017-05-16 11:56 ` Javier Martinez Canillas
2017-05-22 11:06 ` Lee Jones
2017-05-22 12:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522120648.zfgf25d7senf3ny2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=javier@dowhile0.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®