From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933313AbdEVM4k (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 08:56:40 -0400
Received: from mx2.suse.de ([195.135.220.15]:56233 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S933262AbdEVM4j (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 08:56:39 -0400
Date: Mon, 22 May 2017 14:56:34 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        zhong jiang <zhongjiang@huawei.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: hugepage: make hstate_is_gigantic() inline
Message-ID: <20170522125633.GK8509@dhcp22.suse.cz>
References: <20170522124748.3911296-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170522124748.3911296-1-arnd@arndb.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 22-05-17 14:46:57, Arnd Bergmann wrote:
> Ignoring the argument of both alloc_huge_page_node() and hstate_is_gigantic()
> causes a harmless warning:
> 
> mm/memory-failure.c: In function 'new_page':
> mm/memory-failure.c:1493:18: error: unused variable 'hstate' [-Werror=unused-variable]
> 
> Turning one into an inline function makes the compiler see that the variable is
> not meant to be unused.
> 
> Fixes: d81a077951f8 ("mm/madvise: enable (soft|hard) offline of HugeTLB pages at PGD level")
> Fixes: 39b80148ffd7 ("mm/follow_page_mask: add support for hugepage directory entry")

Both these sha1 are unstable because they are in Andrew's mmotm tree and
will change in future next trees. I would just drop them.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

the patch itself looks OK

> ---
>  include/linux/hugetlb.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 76b9ddcd8c3c..c92a1f0c7240 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -532,7 +532,11 @@ struct hstate {};
>  #define vma_mmu_pagesize(v) PAGE_SIZE
>  #define huge_page_order(h) 0
>  #define huge_page_shift(h) PAGE_SHIFT
> -#define hstate_is_gigantic(h) 0
> +static inline bool hstate_is_gigantic(struct hstate *h)
> +{
> +	return false;
> +}
> +
>  static inline unsigned int pages_per_huge_page(struct hstate *h)
>  {
>  	return 1;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs