From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758938AbdEVNII (ORCPT ); Mon, 22 May 2017 09:08:08 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:56837 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdEVNIC (ORCPT ); Mon, 22 May 2017 09:08:02 -0400 From: Arnd Bergmann To: Ike Panhc , Darren Hart , Andy Shevchenko Cc: Arnd Bergmann , =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= , Brian Masney , Ritesh Raj Sarraf , Mika Westerberg , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: ideapad-laptop: hide unused 'touchpad_store' Date: Mon, 22 May 2017 15:07:03 +0200 Message-Id: <20170522130709.242445-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:IfCXPgCpYjKKhXW+cDLoILpLFBxTK01vBlhC2vTIlAynRx3Y8WH HMAZDR9MKW4dMwFeYgFBB8c4WBB/kgetIdMxnKlxgP4ptOm2q9Fq+/BY9tfIdmTd2YruDoU EIpJ0TRW8JYiU+1NVe2UJREcduNInOQZc2eSLEumnRJxc1gHOg8p4tHpuYiYoeWoMCzJOLC xy+8w/ic+eohOiqdVARBg== X-UI-Out-Filterresults: notjunk:1;V01:K0:g1qJgHN3jIE=:NFYrVJHtWaqWCOeC3n9H/U iXjfiJj6PTV8bL2Xa+Tp+tR/2mOWBQTc7fKJlAp4ud0A3DXsqhny+f7kNRWB3PY5xToKwGX+t mYG4GEguXmbCYy9ss35cbrpHHPWT+uPQhq5qhWX6bzqPWhn2Q/VAupv9V+oEgyvCd+rZmEGZH qYG/6BKBndcqPMyHlPpZJO+GO2gMclJgT/VsCK/ZsWdI09ZesRZW0SYcti35L4vftQ3Pznjr4 sHICN3uaJ6o2ZpvnQ5MOyfyXRujetU1gI8SE4sAK+mmfW9g9OgFbffrLk7r2HHBOwxlZsLlw8 4/x7eAiHdzl5fwEQQlcyq1ayb1/bJKfS/769/Say0F/yHXtoCLN59TpVUroYbbAX2jjHETPnF nB7lbTVup/uyvWyCwNP9grjELF9Hg+7P83hr7TK4LRNdqDfkN/ubAAsynkTUHtCaSTmOZZ2mz 7cGqcceeZBvsysvVMmgKB58AcVFooHugf0sRsRIuT9yCmUnB2k2VuUwpXJcV+8pjdh43JCGXV QPEKxXc+l2KAYo3d/dbKm2S88HMrUr7sg4Zn8zSqysp1XGeDhednSvU+gnRROLrdD+hqTpBW8 /i5aTDkwJR9Q3NSwY3SVV9dEkCNvg6BbV6Teak+TpsplMGdFMfyyANb+NHvgnB49hMV068Rzo hDjn6WzwMnTmEFmFXRkMjc81LyWDoGXCCMiwxpiy17POUPR51z7WFu+tNVxybfMgkqBY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A readonly sysfs property must not have a 'store' function: drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function] We can either comment it out or remove the function entirely, without a good reason one or or another I picked the second option. Fixes: 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO") Signed-off-by: Arnd Bergmann --- drivers/platform/x86/ideapad-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index f7a4608cc60b..c4c7ae3179c0 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -435,6 +435,8 @@ static ssize_t touchpad_show(struct device *dev, return sprintf(buf, "%lu\n", result); } +#if 0 +/* Switch to RO for now: It might be revisited in the future */ static ssize_t touchpad_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -453,7 +455,7 @@ static ssize_t touchpad_store(struct device *dev, return count; } -/* Switch to RO for now: It might be revisited in the future */ +#endif static DEVICE_ATTR_RO(touchpad); static struct attribute *ideapad_attributes[] = { -- 2.9.0