From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759565AbdEVNTb (ORCPT ); Mon, 22 May 2017 09:19:31 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33668 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759395AbdEVNT2 (ORCPT ); Mon, 22 May 2017 09:19:28 -0400 From: Nikita Yushchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy , Jeff White , Nikita Yushchenko Subject: [PATCH] spi: spi-fsl-dspi: ensure non-zero return on error path Date: Mon, 22 May 2017 16:19:20 +0300 Message-Id: <20170522131920.4828-1-nikita.yoush@cogentembedded.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Propagate error return from dspi_request_dma() into probe routine's return. Signed-off-by: Nikita Yushchenko --- drivers/spi/spi-fsl-dspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 15201645bdc4..d89127f4a46d 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -1032,7 +1032,8 @@ static int dspi_probe(struct platform_device *pdev) goto out_master_put; if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) { - if (dspi_request_dma(dspi, res->start)) { + ret = dspi_request_dma(dspi, res->start); + if (ret < 0) { dev_err(&pdev->dev, "can't get dma channels\n"); goto out_clk_put; } -- 2.11.0