From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935781AbdEVVLw (ORCPT ); Mon, 22 May 2017 17:11:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932935AbdEVVLv (ORCPT ); Mon, 22 May 2017 17:11:51 -0400 Date: Mon, 22 May 2017 14:11:49 -0700 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM Message-Id: <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> In-Reply-To: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual wrote: > There are many places where we define size either left shifting integers > or multiplying 1024s without any generic definition to fall back on. But > there are couples of (powerpc and lz4) attempts to define these standard > memory sizes. Lets move these definitions to core VM to make sure that > all new usage come from these definitions eventually standardizing it > across all places. Grep further - there are many more definitions and some may now generate warnings. Newly including mm.h for these things seems a bit heavyweight. I can't immediately think of a more appropriate place. Maybe printk.h or kernel.h.