From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934554AbdEVVj1 (ORCPT ); Mon, 22 May 2017 17:39:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44498 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933917AbdEVVj0 (ORCPT ); Mon, 22 May 2017 17:39:26 -0400 Date: Mon, 22 May 2017 14:39:25 -0700 From: Andrew Morton To: Matthias Kaehlcke Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block Message-Id: <20170522143925.3a7483acaee4b5ed2987cae1@linux-foundation.org> In-Reply-To: <20170522211326.66973-1-mka@chromium.org> References: <20170522211326.66973-1-mka@chromium.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017 14:13:26 -0700 Matthias Kaehlcke wrote: > The function is not used when CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y. > Adding the #ifdef fixes the following warning when building with clang: > > lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16' > [-Werror,-Wunused-function] > > ... > > --- a/lib/zlib_inflate/inffast.c > +++ b/lib/zlib_inflate/inffast.c > @@ -26,6 +26,7 @@ union uu { > unsigned char b[2]; > }; > > +#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > /* Endian independed version */ > static inline unsigned short > get_unaligned16(const unsigned short *p) > @@ -37,6 +38,7 @@ get_unaligned16(const unsigned short *p) > mm.b[1] = b[1]; > return mm.us; > } > +#endif > > #ifdef POSTINC > # define OFF 0 Do we really want to mucky up the source code to keep clang happy? gcc won't warn about an unused static inline. Can we configure clang to do the same?