From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935356AbdEVPVp (ORCPT ); Mon, 22 May 2017 11:21:45 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:56883 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934647AbdEVPVo (ORCPT ); Mon, 22 May 2017 11:21:44 -0400 From: Arnd Bergmann To: Eric Anholt , David Airlie Cc: Arnd Bergmann , Kukjin Kim , Krzysztof Kozlowski , Colin Ian King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/pl111: add ARM_AMBA dependency Date: Mon, 22 May 2017 17:20:08 +0200 Message-Id: <20170522152058.3346428-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:dnpnckp70lFrtxhPJCXPvGDweDWuftUgBXbnvNdoCnYIiJOG8JD O9QxOW7C7jREXcbYKH9198aw9zpkJBv6kwbxyl5NwKGv6pRtJPmGFzUXAXuiCyA5bBt7fLg jrXn7enQOcM74Bdh/uo6oVk5Gmd0F9OZaUWLRHUgN9r98eOroRGwaAG1Gz8qYplgx0UzE1B 6UTudDvRuaZAXzWNyM1Bg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ngoN190yWb8=:wbUU1obHlAJ8Lf2bxUsBg1 8GWV2XdvktZMEL1uZBi1HYy2WVDBXiTC+kV35rWbwt0dA2Qi2Mi0AnwBcjN5LCDGNM7WfM4pp 5smaodk8jlyqsr6wYZg6U99ZacmfUYUECRw3qPc20Ok3QywPHmcM2vo8uQUCHLSpgzeRr+mlC 3Ge/jctuYJCbm5jwFUa+KbWctD4SWZnQbeuj8XHqy3N2MpCaQVGLR3Js2CAwrWUemL1eaLCE0 0QI40SOUkHK3u3l2UdqkrzeZc2mwK4mKheUEa1VgyCW4o9iB0GGyd3muhk5Any1GJ3f5+OD3w xXV1FZKJoMXnN+jxRGsNf6sDOCFeLsoZOfjWYRRSEDVjzTiv1U51Pmn0WlHBRJtGiqOmYPwUo PXcEPwaM6C26rEWAdRd7A9EWaJtYQkPv+uqBBwqzgWvRuPNvrWICLo7NG4g/4lMQyVfqUIe1t lLFoWECXaxsg2vhYxrJIqejUlmT8EVCRuRy/umljY1lBMzzHKWeRBEj9k45F8nHPGTlJQzIEw wiErSXYrlrYndX6LfhIBF9bhSUaysDfIWPWdesn6DGiT7b+lLJ9+tCiEIL66Nm1sQOQPtLrF+ FjzLSn7jyducvMESIxEKZ7LvoPNcVRgszAv62C6VylktyQ+FSGohbMz4fG88vMeh51QKiRtdc ZnE33+hITTTtzpxKHBDBwA+npWIxi1kOvp+DBBuob6IDjZsM78wH5DOgbtCwBo7b5Hss= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, but it just causes needless warnings: drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function] This removes the #ifdef instead, and adds a dependency on ARM_AMBA to only let us build the driver when the base support is enabled. Unfortunately, this requires removing one redundant 'select ARM_AMBA' line from mach-s3c64xx to avoid a circular dependency. It might be good to allow manually enabling ARM_AMBA when COMPILE_TEST is turned on, but that should be a separate patch and may cause other build regressions. Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Signed-off-by: Arnd Bergmann --- arch/arm/mach-s3c64xx/Kconfig | 1 - drivers/gpu/drm/pl111/Kconfig | 1 + drivers/gpu/drm/pl111/pl111_drv.c | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig index 459214fa20b4..5ee5ad74a3d6 100644 --- a/arch/arm/mach-s3c64xx/Kconfig +++ b/arch/arm/mach-s3c64xx/Kconfig @@ -40,7 +40,6 @@ config CPU_S3C6410 config S3C64XX_PL080 def_bool DMADEVICES - select ARM_AMBA select AMBA_PL08X config S3C64XX_SETUP_SDHCI diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 309f4fd52de7..e2f393fcc4bf 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -2,6 +2,7 @@ config DRM_PL111 tristate "DRM Support for PL111 CLCD Controller" depends on DRM depends on ARM || ARM64 || COMPILE_TEST + depends on ARM_AMBA depends on COMMON_CLK select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index 97095b1aa961..dce382f97f8c 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -179,7 +179,6 @@ static struct drm_driver pl111_drm_driver = { #endif }; -#ifdef CONFIG_ARM_AMBA static int pl111_amba_probe(struct amba_device *amba_dev, const struct amba_id *id) { @@ -262,7 +261,6 @@ static struct amba_driver pl111_amba_driver = { }; module_amba_driver(pl111_amba_driver); -#endif /* CONFIG_ARM_AMBA */ MODULE_DESCRIPTION(DRIVER_DESC); MODULE_AUTHOR("ARM Ltd."); -- 2.9.0