From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935829AbdEVQcj (ORCPT ); Mon, 22 May 2017 12:32:39 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34546 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934315AbdEVQcf (ORCPT ); Mon, 22 May 2017 12:32:35 -0400 Date: Mon, 22 May 2017 18:32:31 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Cc: Eric Anholt , David Airlie , Kukjin Kim , Colin Ian King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/pl111: add ARM_AMBA dependency Message-ID: <20170522163231.bk6zltgzse4szm2o@kozik-lap> References: <20170522152058.3346428-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170522152058.3346428-1-arnd@arndb.de> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: > The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] > drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function] > > This removes the #ifdef instead, and adds a dependency on ARM_AMBA to > only let us build the driver when the base support is enabled. > > Unfortunately, this requires removing one redundant 'select ARM_AMBA' > line from mach-s3c64xx to avoid a circular dependency. > > It might be good to allow manually enabling ARM_AMBA when COMPILE_TEST > is turned on, but that should be a separate patch and may cause other > build regressions. > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c64xx/Kconfig | 1 - > drivers/gpu/drm/pl111/Kconfig | 1 + > drivers/gpu/drm/pl111/pl111_drv.c | 2 -- > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig > index 459214fa20b4..5ee5ad74a3d6 100644 > --- a/arch/arm/mach-s3c64xx/Kconfig > +++ b/arch/arm/mach-s3c64xx/Kconfig > @@ -40,7 +40,6 @@ config CPU_S3C6410 > > config S3C64XX_PL080 > def_bool DMADEVICES > - select ARM_AMBA I must admit that I miss how pl111 DRM driver create circular dependency with S3C64XX_PL080 (or AMBA_PL08X?). Maybe it is unrelated change and should be a separate patch? Best regards, Krzysztof > select AMBA_PL08X > > config S3C64XX_SETUP_SDHCI > diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig > index 309f4fd52de7..e2f393fcc4bf 100644 > --- a/drivers/gpu/drm/pl111/Kconfig > +++ b/drivers/gpu/drm/pl111/Kconfig > @@ -2,6 +2,7 @@ config DRM_PL111 > tristate "DRM Support for PL111 CLCD Controller" > depends on DRM > depends on ARM || ARM64 || COMPILE_TEST > + depends on ARM_AMBA > depends on COMMON_CLK > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c > index 97095b1aa961..dce382f97f8c 100644 > --- a/drivers/gpu/drm/pl111/pl111_drv.c > +++ b/drivers/gpu/drm/pl111/pl111_drv.c > @@ -179,7 +179,6 @@ static struct drm_driver pl111_drm_driver = { > #endif > }; > > -#ifdef CONFIG_ARM_AMBA > static int pl111_amba_probe(struct amba_device *amba_dev, > const struct amba_id *id) > { > @@ -262,7 +261,6 @@ static struct amba_driver pl111_amba_driver = { > }; > > module_amba_driver(pl111_amba_driver); > -#endif /* CONFIG_ARM_AMBA */ > > MODULE_DESCRIPTION(DRIVER_DESC); > MODULE_AUTHOR("ARM Ltd."); > -- > 2.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html