From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761168AbdEWFPc convert rfc822-to-8bit (ORCPT ); Tue, 23 May 2017 01:15:32 -0400 Received: from smtprelay0060.hostedemail.com ([216.40.44.60]:36746 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761140AbdEWFPb (ORCPT ); Tue, 23 May 2017 01:15:31 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:152:355:379:541:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1513:1515:1516:1518:1521:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2892:3138:3139:3140:3141:3142:3352:3622:3865:3867:4250:5007:6261:7576:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12555:12740:12895:13069:13138:13161:13229:13231:13255:13311:13357:14096:14097:14181:14659:14721:21080:21433:21451:21627:30012:30029:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: scarf45_4d05d7caf5251 X-Filterd-Recvd-Size: 2290 Date: Tue, 23 May 2017 01:15:18 -0400 From: Steven Rostedt To: SF Markus Elfring Cc: Ingo Molnar , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() Message-ID: <20170523011518.4a81aad6@vmware.local.home> In-Reply-To: <392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net> References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> <392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 May 2017 23:03:23 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 5 May 2017 20:00:11 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the following. > > Comparison to NULL could be written !… > > Thus fix the affected source code place. > > Signed-off-by: Markus Elfring > --- > kernel/trace/trace_events_hist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events_hist.c > b/kernel/trace/trace_events_hist.c index df566e21344d..36412deac24c > 100644 --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -1324,7 +1324,7 @@ static bool compatible_field(struct > ftrace_event_field *field, { > if (field == test_field) > return true; > - if (field == NULL || test_field == NULL) > + if (!field || !test_field) The first two are fine, this one isn't needed. -- Steve > return false; > if (strcmp(field->name, test_field->name) != 0) > return false;