From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934549AbdEWFcB (ORCPT ); Tue, 23 May 2017 01:32:01 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:58154 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860AbdEWFb7 (ORCPT ); Tue, 23 May 2017 01:31:59 -0400 Date: Tue, 23 May 2017 07:31:55 +0200 From: Simon Horman To: Arnd Bergmann Cc: Ulf Hansson , Wolfram Sang , Chris Brandt , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe Message-ID: <20170523053155.GD25840@verge.net.au> References: <20170522133339.798278-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170522133339.798278-1-arnd@arndb.de> Organisation: Horms Solutions BV User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 03:33:08PM +0200, Arnd Bergmann wrote: > We now build the sdhi driver in separate modules, which means we > have to export the symbols that are called from another module: > > ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined! > ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined! > > Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file") Sorry for messing this up and thanks for the fix. > Signed-off-by: Arnd Bergmann > --- > drivers/mmc/host/renesas_sdhi_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 846ee1a8e5a6..fa6c188e0327 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > eprobe: > return ret; > } > +EXPORT_SYMBOL_GPL(renesas_sdhi_probe); > > int renesas_sdhi_remove(struct platform_device *pdev) > { > @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev) > > return 0; > } > +EXPORT_SYMBOL_GPL(renesas_sdhi_remove); > -- > 2.9.0 >