From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965122AbdEWIkS (ORCPT ); Tue, 23 May 2017 04:40:18 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41810 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934431AbdEWIkO (ORCPT ); Tue, 23 May 2017 04:40:14 -0400 Date: Tue, 23 May 2017 01:40:07 -0700 From: Christoph Hellwig To: Vlastimil Babka Cc: Christoph Hellwig , Andrew Morton , Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM Message-ID: <20170523084007.GA10308@infradead.org> References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> <20170523070227.GA27864@infradead.org> <09a6bafa-5743-425e-8def-bd9219cd756c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09a6bafa-5743-425e-8def-bd9219cd756c@suse.cz> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 10:38:17AM +0200, Vlastimil Babka wrote: > Those defined in the patch are binary, not decimal. Do we even need > decimal ones? Oh, good point. In which case the names should change to avoid the confusion.