From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965617AbdEWKF3 (ORCPT ); Tue, 23 May 2017 06:05:29 -0400 Received: from foss.arm.com ([217.140.101.70]:49370 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934440AbdEWKFZ (ORCPT ); Tue, 23 May 2017 06:05:25 -0400 Date: Tue, 23 May 2017 11:04:47 +0100 From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, ganapatrao.kulkarni@cavium.com Subject: Re: [PATCH 0/2] perf stat: fix segfault when closing events Message-ID: <20170523100446.GB14542@leverpostej> References: <1493380030-4683-1-git-send-email-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493380030-4683-1-git-send-email-mark.rutland@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Does anyone have any comments on these? I'm happy to rebase/resend if necessary. I'd very much like to see this fixed. Thanks, Mark. On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote: > Hi, > > These patches fix a segfault seen in some cases when perf stat is exiting. > > We don't balance opening/closing of events in all cases, and go out-of-bounds > when we close events. Full details in the patch 2 commit message. > > Thanks, > Mark. > > Mark Rutland (2): > perf evsel: add per{cpu,thread} close helpers > perf stat: balance opening/closing of events > > tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++- > tools/perf/util/evsel.c | 26 ++++++++++++++++++++------ > tools/perf/util/evsel.h | 4 ++++ > 3 files changed, 47 insertions(+), 7 deletions(-) > > -- > 1.9.1 >