mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Felix Kuehling <felix.kuehling@amd.com>
Cc: <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Harish Kasiviswanathan <harish.kasiviswanathan@amd.com>
Subject: Re: [PATCH] kernel: Export mm_access
Date: Tue, 23 May 2017 14:14:11 -0700	[thread overview]
Message-ID: <20170523141411.7e919ef626429d16926ae155@linux-foundation.org> (raw)
In-Reply-To: <5a9607b4-d2ac-fc7b-e43b-1e73c2651071@amd.com>

On Tue, 23 May 2017 16:17:29 -0400 Felix Kuehling <felix.kuehling@amd.com> wrote:

> From: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
> 
> Exporting mm_access, which is required for implementing accelerated
> equivalents of process_vm_readv/process_vm_writev for GPU memory in KFD
> (AMD's GPU compute driver). This allows us to apply all the same remote
> process memory access policies.
> 
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> Current KFD with AMD discrete GPU support is not yet upstream, but we
> are working on getting it upstream for 4.13 or 4.14 depending on how we
> line up with Dave Airlie's merge windows.
> 
> For reference, recent releases of ROCm (AMD's Radeon Open Compute
> Platform software stack) with fully open-source user mode and kernel
> code can be found on GitHub:
> https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/roc-1.5.0

Well if we're going to export it, I suppose we should actually document
it.  Could you please include some commentary above mm_access() which
describes what it does, why it does it, return value, etc?

Then please include this patch in whatever tree contains the KFD code,
with my Acked-by: Andrew Morton <akpm@linux-foundation.org>.

> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1060,6 +1060,7 @@ struct mm_struct *mm_access(struct task_struct
> *task, unsigned int mode)
> 
>  	return mm;
>  }
> +EXPORT_SYMBOL_GPL(mm_access);
> 
>  static void complete_vfork_done(struct task_struct *tsk)
>  {

fyi, your email client is word-wrapping the patches.

      reply	other threads:[~2017-05-23 21:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 20:17 Felix Kuehling
2017-05-23 21:14 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523141411.7e919ef626429d16926ae155@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=felix.kuehling@amd.com \
    --cc=harish.kasiviswanathan@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®