From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Use case for TASKS_RCU
Date: Tue, 23 May 2017 16:38:53 -0400 [thread overview]
Message-ID: <20170523163853.70773f4a@vmware.local.home> (raw)
In-Reply-To: <20170523200035.GW3956@linux.vnet.ibm.com>
On Tue, 23 May 2017 13:00:35 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> > > Unfortunately, it does not work, as I should have known ahead of
> > > time from the dyntick-idle experience. Not all context switches
> > > go through context_switch(). :-/
> >
> > Wait. What context switch doesn't go through a context switch? Or do
> > you mean a user/kernel context switch?
>
> I mean that putting printk() before and after the call to
> context_switch() can show tasks switching out twice without switching
> in and vice versa. No sign of lost printk()s, and I also confirmed
> this behavior using a flag in task_struct.
I hope you meant trace_printk()s' as printk is a huge overhead and can
cause side effects.
>
> One way that this can happen on some architectures is via the "helper"
> mechanism, where the task sleeps normally, but where a later interrupt
> or exception takes on its context "behind the scenes" in the arch
> code. This is what messed up my attempt to use a simple
> interrupt-nesting counter for RCU dynticks some years back. What I
> counted on there was that the idle loop would never do that sort of
> thing, so I could zero the count when entering idle from process
> context.
>
> But I have not yet found a similar trick for counting voluntary
> context switches.
>
> I also tried making context_switch() look like a momentary quiescent
> state, but of course that means that tasks that block forever also
> block the grace period forever. At which point, I need to scan the
> task list to find them. And that pretty much brings me back to the
> current RCU-tasks implementation. :-/
>
Nothing should block in a preempted state forever, and if it does, that
means we want to wait forever. Because it could be preempted on the
trampoline.
-- Steve
next prev parent reply other threads:[~2017-05-23 20:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 18:23 Paul E. McKenney
2017-05-15 18:48 ` Steven Rostedt
2017-05-15 20:12 ` Paul E. McKenney
2017-05-16 6:22 ` Ingo Molnar
2017-05-16 12:23 ` Paul E. McKenney
2017-05-16 13:07 ` Steven Rostedt
2017-05-24 9:37 ` Masami Hiramatsu
2017-05-19 6:23 ` Ingo Molnar
2017-05-19 13:35 ` Paul E. McKenney
2017-05-19 14:04 ` Steven Rostedt
2017-05-19 14:23 ` Steven Rostedt
2017-05-19 19:06 ` Paul E. McKenney
2017-05-23 0:00 ` Paul E. McKenney
2017-05-23 5:19 ` Steven Rostedt
2017-05-23 15:33 ` Paul E. McKenney
2017-05-23 19:39 ` Steven Rostedt
2017-05-23 20:00 ` Paul E. McKenney
2017-05-23 20:38 ` Steven Rostedt [this message]
2017-05-23 21:10 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523163853.70773f4a@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome