From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch/rcu: Fix stacking of patches when RCU infrastructure is patched
Date: Tue, 23 May 2017 12:52:47 -0500 [thread overview]
Message-ID: <20170523175247.akvppkoi55foh5my@treble> (raw)
In-Reply-To: <1495554451-13481-1-git-send-email-pmladek@suse.com>
On Tue, May 23, 2017 at 05:47:31PM +0200, Petr Mladek wrote:
> diff --git a/kernel/livepatch/patch.c b/kernel/livepatch/patch.c
> index f8269036bf0b..08acba30ecec 100644
> --- a/kernel/livepatch/patch.c
> +++ b/kernel/livepatch/patch.c
> @@ -59,7 +59,11 @@ static void notrace klp_ftrace_handler(unsigned long ip,
>
> ops = container_of(fops, struct klp_ops, fops);
>
> - rcu_read_lock();
> + /*
> + * A variant of synchronize_sched() is used to allow pathing functions
> + * where RCU is not wathing, see klp_synchronize_transition().
> + */
> + preempt_disable_notrace();
s/pathing/patching/
s/wathing/watching/
(and same for the duplicated version of the comment below.)
Otherwise the patch looks promising, though I'll need to stare at it for
a while...
--
Josh
next prev parent reply other threads:[~2017-05-23 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 15:47 Petr Mladek
2017-05-23 17:52 ` Josh Poimboeuf [this message]
2017-05-24 18:41 ` Paul E. McKenney
2017-06-06 11:07 ` Miroslav Benes
2017-06-08 16:26 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523175247.akvppkoi55foh5my@treble \
--to=jpoimboe@redhat.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®