From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933545AbdEWShq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 14:37:46 -0400
Received: from mail-yb0-f176.google.com ([209.85.213.176]:36468 "EHLO
        mail-yb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S967926AbdEWShn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 14:37:43 -0400
Date: Tue, 23 May 2017 14:37:40 -0400
From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        viro@zeniv.linux.org.uk, Kernel-team@fb.com
Subject: Re: [PATCH 4/5] kernfs: don't set dentry->d_fsdata
Message-ID: <20170523183740.GA13222@htj.duckdns.org>
References: <cover.1495490800.git.shli@fb.com>
 <569790908deae2d9f32165b8844ad9f3c0f38589.1495490800.git.shli@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569790908deae2d9f32165b8844ad9f3c0f38589.1495490800.git.shli@fb.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On Mon, May 22, 2017 at 03:53:08PM -0700, Shaohua Li wrote:
> +#define kernfs_dentry_node(d)  ((d_inode(d))->i_private)

This would oops on a negative dentry.  We need to test d_inode(d) for
NULL first.

Thanks.

-- 
tejun