From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764268AbdEWS50 (ORCPT ); Tue, 23 May 2017 14:57:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:47120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761795AbdEWS5U (ORCPT ); Tue, 23 May 2017 14:57:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D449823956 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Tue, 23 May 2017 13:57:18 -0500 From: Bjorn Helgaas To: Jisheng Zhang Cc: bhelgaas@google.com, jingoohan1@gmail.com, Joao.Pinto@synopsys.com, svarbanov@mm-sol.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] PCI: dwc/host: Mark PCIe/PCI (MSI) cascade ISR as IRQF_NO_THREAD Message-ID: <20170523185718.GC2637@bhelgaas-glaptop.roam.corp.google.com> References: <20170420102718.3778-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170420102718.3778-1-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2017 at 06:27:18PM +0800, Jisheng Zhang wrote: > Similar as commit 8ff0ef996ca0 ("PCI: host: Mark PCIe/PCI (MSI) IRQ > cascade handlers as IRQF_NO_THREAD"), we should mark PCIe/PCI (MSI) > IRQ cascade handlers IRQF_NO_THREAD explicitly. I just found this > issue in pcie-designware-plat driver, then searched the code, I think > we should fix pcie-qcom and vmd as well. > > Signed-off-by: Jisheng Zhang Applied with ack/reviewed-by from Jingoo and Keith to pci/host-designware for v4.13, thanks! > --- > drivers/pci/dwc/pcie-designware-plat.c | 3 ++- > drivers/pci/dwc/pcie-qcom.c | 3 ++- > drivers/pci/host/vmd.c | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-designware-plat.c b/drivers/pci/dwc/pcie-designware-plat.c > index f20d494922ab..0db1dafc82bb 100644 > --- a/drivers/pci/dwc/pcie-designware-plat.c > +++ b/drivers/pci/dwc/pcie-designware-plat.c > @@ -67,7 +67,8 @@ static int dw_plat_add_pcie_port(struct pcie_port *pp, > > ret = devm_request_irq(dev, pp->msi_irq, > dw_plat_pcie_msi_irq_handler, > - IRQF_SHARED, "dw-plat-pcie-msi", pp); > + IRQF_SHARED | IRQF_NO_THREAD, > + "dw-plat-pcie-msi", pp); > if (ret) { > dev_err(dev, "failed to request MSI IRQ\n"); > return ret; > diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c > index 67eb7f5926dd..a5570c58081e 100644 > --- a/drivers/pci/dwc/pcie-qcom.c > +++ b/drivers/pci/dwc/pcie-qcom.c > @@ -727,7 +727,8 @@ static int qcom_pcie_probe(struct platform_device *pdev) > > ret = devm_request_irq(dev, pp->msi_irq, > qcom_pcie_msi_irq_handler, > - IRQF_SHARED, "qcom-pcie-msi", pp); > + IRQF_SHARED | IRQF_NO_THREAD, > + "qcom-pcie-msi", pp); > if (ret) { > dev_err(dev, "cannot request msi irq\n"); > return ret; > diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c > index e27ad2a3bd33..784f63beb487 100644 > --- a/drivers/pci/host/vmd.c > +++ b/drivers/pci/host/vmd.c > @@ -704,7 +704,8 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id) > > INIT_LIST_HEAD(&vmd->irqs[i].irq_list); > err = devm_request_irq(&dev->dev, pci_irq_vector(dev, i), > - vmd_irq, 0, "vmd", &vmd->irqs[i]); > + vmd_irq, IRQF_NO_THREAD, > + "vmd", &vmd->irqs[i]); > if (err) > return err; > } > -- > 2.11.0 >