From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764968AbdEWUKd (ORCPT ); Tue, 23 May 2017 16:10:33 -0400 Received: from mail-yb0-f196.google.com ([209.85.213.196]:33351 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbdEWUKc (ORCPT ); Tue, 23 May 2017 16:10:32 -0400 Date: Tue, 23 May 2017 16:10:29 -0400 From: Tejun Heo To: Michael Bringmann Cc: Lai Jiangshan , linux-kernel@vger.kernel.org, Nathan Fontenot Subject: Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot Message-ID: <20170523201029.GH13222@htj.duckdns.org> References: <20170510173340.GF32165@htj.duckdns.org> <20170516155527.GB6389@htj.duckdns.org> <20170523194952.GF13222@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, May 23, 2017 at 03:09:07PM -0500, Michael Bringmann wrote: > To confirm, you want the WARN_ON(cpumask_any(pool->attrs->cpumask) >= NR_CPUS) > at the point where I place my current patch? Yeah, cpumask_weight() probably is a bit more intuitive but I'm curious why we're creating workqueues for a node before cpus come online. Thanks. -- tejun