From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033093AbdEWVph (ORCPT ); Tue, 23 May 2017 17:45:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:36162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031360AbdEWVpd (ORCPT ); Tue, 23 May 2017 17:45:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B48E223980 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Tue, 23 May 2017 16:45:31 -0500 From: Bjorn Helgaas To: Piotr Gregor Cc: Alex Williamson , Piotr Gregor , bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: Handle the case when PCI_COMMAND register hasn't changed in INTx masking test Message-ID: <20170523214531.GB20928@bhelgaas-glaptop.roam.corp.google.com> References: <20170510122959.4uupohiz3ukzm4c4@debian1.home> <20170522233820.GH19733@bhelgaas-glaptop.roam.corp.google.com> <20170523161929.GA24431@bhelgaas-glaptop.roam.corp.google.com> <20170523103904.3a20d0cc@w520.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 08:14:26PM +0100, Piotr Gregor wrote: > Would the pci_setup_device() be a good place to move this check to? Seems like a reasonable place.