From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030795AbdEXTc2 (ORCPT ); Wed, 24 May 2017 15:32:28 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49436 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940867AbdEXTc0 (ORCPT ); Wed, 24 May 2017 15:32:26 -0400 Date: Wed, 24 May 2017 15:32:24 -0400 (EDT) Message-Id: <20170524.153224.1230164587077679673.davem@davemloft.net> To: glider@google.com Cc: dvyukov@google.com, kcc@google.com, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error From: David Miller In-Reply-To: <20170523112028.132630-1-glider@google.com> References: <20170523112028.132630-1-glider@google.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 May 2017 11:50:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Potapenko Date: Tue, 23 May 2017 13:20:28 +0200 > rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led > to contents of |ifm| being uninitialized because nlh->nlmsglen was too > small to accommodate |ifm|. The uninitialized data may affect some > branches and result in unwanted effects, although kernel data doesn't > seem to leak to the userspace directly. > > The bug has been detected with KMSAN and syzkaller. > > Signed-off-by: Alexander Potapenko Applied, thanks.