From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162426AbdEXAKg (ORCPT ); Tue, 23 May 2017 20:10:36 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33580 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759783AbdEXAHw (ORCPT ); Tue, 23 May 2017 20:07:52 -0400 From: Dmitry Torokhov To: Greg Kroah-Hartman Cc: Wei-Ning Huang , Julius Werner , Guenter Roeck , linux-kernel@vger.kernel.org Subject: [PATCH 3/8] firmware: vpd: avoid potential use-after-free when destroying section Date: Tue, 23 May 2017 17:07:43 -0700 Message-Id: <20170524000748.39310-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170524000748.39310-1-dmitry.torokhov@gmail.com> References: <20170524000748.39310-1-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should not free info->key before we remove sysfs attribute that uses this data as its name. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Dmitry Torokhov --- drivers/firmware/google/vpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index acf3f3cdc3f8..b3a6e918418b 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -157,8 +157,8 @@ static void vpd_section_attrib_destroy(struct vpd_section *sec) struct vpd_attrib_info *temp; list_for_each_entry_safe(info, temp, &sec->attribs, list) { - kfree(info->key); sysfs_remove_bin_file(sec->kobj, &info->bin_attr); + kfree(info->key); kfree(info); } } -- 2.13.0.219.gdb65acc882-goog