From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935685AbdEXAJN (ORCPT ); Tue, 23 May 2017 20:09:13 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34840 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760717AbdEXAHy (ORCPT ); Tue, 23 May 2017 20:07:54 -0400 From: Dmitry Torokhov To: Greg Kroah-Hartman Cc: Wei-Ning Huang , Julius Werner , Guenter Roeck , linux-kernel@vger.kernel.org Subject: [PATCH 4/8] firmware: vpd: do not leak kobjects Date: Tue, 23 May 2017 17:07:44 -0700 Message-Id: <20170524000748.39310-4-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog In-Reply-To: <20170524000748.39310-1-dmitry.torokhov@gmail.com> References: <20170524000748.39310-1-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kobject_del() only unlinks kobject, we need to use kobject_put() to make sure kobject will go away completely. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Dmitry Torokhov --- drivers/firmware/google/vpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index b3a6e918418b..cb07a2984ece 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -243,7 +243,7 @@ static int vpd_section_destroy(struct vpd_section *sec) { if (sec->enabled) { vpd_section_attrib_destroy(sec); - kobject_del(sec->kobj); + kobject_put(sec->kobj); sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr); kfree(sec->raw_name); iounmap(sec->baseaddr); @@ -330,7 +330,7 @@ static void __exit vpd_platform_exit(void) { vpd_section_destroy(&ro_vpd); vpd_section_destroy(&rw_vpd); - kobject_del(vpd_kobj); + kobject_put(vpd_kobj); } module_init(vpd_platform_init); -- 2.13.0.219.gdb65acc882-goog